From owner-svn-src-head@freebsd.org Wed Sep 21 07:26:14 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 926C7BE38CE; Wed, 21 Sep 2016 07:26:14 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1EE953F4; Wed, 21 Sep 2016 07:26:14 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm0-x22e.google.com with SMTP id w84so175725526wmg.1; Wed, 21 Sep 2016 00:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=OE3+iguipHQ/A0RMFQL4orth61CnG+DRB+w2z2nj240=; b=kwoSM8PGUYayk/zYzgSIkmO+/0eBGl++hu42vN12kF7pEqoWavNugZfpMemqWV7CQ2 mNfk0A7oV4UGgj2Y0ky46rZsGg5SNNttGtEnGhwaallGF+IzhbeccBiCbaLuua8dlrIC 9strB4gSMqK/nWuvFPExvrvbDrISFIdp7M5QEBH4SbfMlXQTUKEJAqT0tUcj06Jar99h LFu7BXkzgZjSZmBacLAm4g4kRR78juxmuNNflxeYsPztvfKO3ZA9nCpIDyTs6qsEum8M ZYoTGGO41jHycTsL11d6D/tzcraQgpb2l1+VxMgTvdNLGhrIMeAyBWMHaQ4T7f6y4Qu6 5uSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=OE3+iguipHQ/A0RMFQL4orth61CnG+DRB+w2z2nj240=; b=KdBAbDEqGxDlISQQYupHMfLGZvADrQ8fjHUxhxupjnZ+/+YHZakeS29kIDKxh54Y+C a/U6kfv8/DUCAeMx2GN3sjVr4EJ8RjoFqe238vfnwD7W1PFzYHwWEagibsmk6Rzy10Qs /RGDmTd00H/uldeTb7Xdn9HhWAdTVEcHCRlbyZN9j52vbUvu60VhGLUlsFOAyGS93EIT nkNwOjRYZPA2OCYS4w0//X4GamcbdjB+YlPXoEHmvT1/tHJDOx32HcOpXE0aqXmQ9JXx N5cfgDw1rmCRRdtvOIjlWNnMUf8rqGkwVSo/gwlVB3Y1HJAQOPPYGG0F4zzf7Rkb49+Z 1Ivw== X-Gm-Message-State: AE9vXwNeQTfDFOaaueUkfzxZz5kgAyLiQAEx2ciuy9uRvmYvLPUnVZ3xp9OAuG4Jx3xkhQ== X-Received: by 10.28.5.133 with SMTP id 127mr1653790wmf.128.1474442772562; Wed, 21 Sep 2016 00:26:12 -0700 (PDT) Received: from brick (acys180.neoplus.adsl.tpnet.pl. [83.11.202.180]) by smtp.gmail.com with ESMTPSA id ya1sm32154983wjb.23.2016.09.21.00.26.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Sep 2016 00:26:11 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Wed, 21 Sep 2016 09:26:09 +0200 From: Edward Tomasz Napierala To: "Ngie Cooper (yaneurabeya)" Cc: Alan Somers , Alexander Motin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r305988 - in head/sys: geom sys Message-ID: <20160921072609.GB25303@brick> Mail-Followup-To: "Ngie Cooper (yaneurabeya)" , Alan Somers , Alexander Motin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: <201609191746.u8JHkFKI071354@repo.freebsd.org> <03DFBBFF-FA98-48CB-8180-B03B37538301@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <03DFBBFF-FA98-48CB-8180-B03B37538301@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 07:26:14 -0000 On 0920T0934, Ngie Cooper (yaneurabeya) wrote: > > > On Sep 20, 2016, at 09:28, Alan Somers wrote: > > > > On Tue, Sep 20, 2016 at 10:23 AM, Alexander Motin wrote: > >> On 20.09.2016 09:20, Alan Somers wrote: > >>> On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala > >>> wrote: > >>>> Author: trasz > >>>> Date: Mon Sep 19 17:46:15 2016 > >>>> New Revision: 305988 > >>>> URL: https://svnweb.freebsd.org/changeset/base/305988 > >>>> > >>>> Log: > >>>> Remove unused bio_taskqueue(). > >>>> > >>>> MFC after: 1 month > >>>> > >>>> Modified: > >>>> head/sys/geom/geom_io.c > >>>> head/sys/sys/bio.h > >>>> > >>> > >>> This is a KBI change, so you should bump __FreeBSD_version. You > >>> probably shouldn't MFC it, either. > >> > >> The last/only consumer of this KPI I know gone with FreeBSD 9 and old > >> ATA stack. Do you know any other? > > > > Nothing in-tree. But it's publicly visible, so we have no way of > > knowing who might be using it out-of-tree. > > I’d have to check, but this might impact us (Isilon). We don’t use the __FreeBSD_version #ifdefs though in our code, so it’s fine from my perspective to leave things alone. > > That being said, are you sure that port klds (e.g. open-vm-tools*) aren’t impacted by this change? Did it go through a ports -exp run? I'm not sure if it's worth it. If something comes up, I'll fix it.