From owner-svn-ports-all@freebsd.org Thu Jan 24 15:24:22 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40EEE14B2D96; Thu, 24 Jan 2019 15:24:22 +0000 (UTC) (envelope-from bhughes@freebsd.org) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D09896F38D; Thu, 24 Jan 2019 15:24:21 +0000 (UTC) (envelope-from bhughes@freebsd.org) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 19E50231F2; Thu, 24 Jan 2019 10:24:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 24 Jan 2019 10:24:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=VyZh9LkT8sm2PdTMNyOJSoINxtNlqPAsW2JPnOQ5H Wc=; b=y62nAAlGZCDo1Mf3dNL+ZjLqtB7XHiRpMR1STQn3C5Kfq4kuLG2Ou1yOt vvr7MlTGR1plk9+1q4MNsyReKMpAMO6ymSBdaJXLlS8zKAq7Iog1DQJZUtJEhkuy cVirPuUqi/A4sOhtVa+3ZSxo+rwiEnOu3owmz21n4kPDXi/qTnNk3eeUGWDCXdil du6VVTIWBejPmGktO/yCYk3OcRTvbyhdnCRPQyQpkiYAP5pC3aeyfmQpakHZW5PS i0TOAFjheBJ8p86lR7hKMArPKjl0DQsWunXxs+aEqQXUSSe7Ofr4v7NLszXouZFa YE3RwrA5AQrl1fPTsjsMguAWXqokw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledriedvgdejgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucenucfjughrpefuhffvfhhokffffgggjggtgfesthekredttdefjeenucfhrhhomh epfdeurhgrughlvgihucfvrdcujfhughhhvghsfdcuoegshhhughhhvghssehfrhgvvggs shgurdhorhhgqeenucffohhmrghinhepohhpthhiohhnshdrmhhknecukfhppeejledrud eitddrudelhedrvdehgeenucfrrghrrghmpehmrghilhhfrhhomhepsghhuhhghhgvshes fhhrvggvsghsugdrohhrghenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from [172.21.17.125] (unknown [79.160.195.254]) by mail.messagingengine.com (Postfix) with ESMTPA id 97C88E4394; Thu, 24 Jan 2019 10:24:19 -0500 (EST) Subject: Re: svn commit: r491058 - head/www/node8 From: "Bradley T. Hughes" To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201901232114.x0NLERHX020332@repo.freebsd.org> <20190123220008.ctao7hiv4flbms7i@atuin.in.mat.cc> <34d14b33-8cef-2be4-3949-85164661c1ae@freebsd.org> Organization: FreeBSD Message-ID: Date: Thu, 24 Jan 2019 16:24:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <34d14b33-8cef-2be4-3949-85164661c1ae@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: D09896F38D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.975,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2019 15:24:22 -0000 On 2019-01-24 05:51, Bradley T. Hughes wrote: > On 2019-01-23 23:00, Mathieu Arnold wrote: >> On Wed, Jan 23, 2019 at 09:14:27PM +0000, Bradley T. Hughes wrote: >>> - >>> -.include >>> - >>> -.if empty(PORT_OPTIONS:MBUNDLED_SSL) >>> - >>> -.if !empty(SSL_DEFAULT:Mlibressl*) >>> -IGNORE=        cannot build node.js with LibreSSL. You must enable >>> BUNDLED_SSL >>> -.endif >>> - >>> -.endif >> >> Mmmm, this is not equivalent, now, the port is always marked as BROKEN >> if the op uses libressl* as their default SSL library, even if >> BUNDLED_SSL is set. >> >> And I think the other changes to the other node* ports are also wrong >> for the same reason. > > Good point, I hadn't considered that. I will fix them now :) Actually, after looking at it more, setting BUNDLED_SSL on any of the www/node* ports causes the port to skip USES+=ssl, which in turn ignores BROKEN_SSL. So, this works as I had intended it; setting DEFAULT_VERSIONS+=ssl=something only matters when BUNDLED_SSL is off, and I have set the defaults such that BUNDLED_SSL is off for FreeBSD versions that have a compatible OpenSSL in base. Changing SSL_DEFAULT can have an impact on whether or not www/node* builds, but that is circumvented by setting BUNDLED_SSL. Thank you for the feedback. I appreciate review and questions about what/how I've done. :) -- Bradley T. Hughes bhughes@freebsd.org