From owner-svn-src-head@FreeBSD.ORG Fri May 3 20:35:50 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 04A42E07; Fri, 3 May 2013 20:35:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 6F36612B8; Fri, 3 May 2013 20:35:49 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r43KZfUB000628; Fri, 3 May 2013 23:35:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.2 kib.kiev.ua r43KZfUB000628 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r43KZflx000627; Fri, 3 May 2013 23:35:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 3 May 2013 23:35:41 +0300 From: Konstantin Belousov To: John Baldwin Subject: Re: svn commit: r250193 - head/sys/fs/msdosfs Message-ID: <20130503203541.GS3047@kib.kiev.ua> References: <201305022000.r42K0Bdk098965@svn.freebsd.org> <201305031155.47559.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4YkaNtrv9TjfxRWe" Content-Disposition: inline In-Reply-To: <201305031155.47559.jhb@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 May 2013 20:35:50 -0000 --4YkaNtrv9TjfxRWe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 03, 2013 at 11:55:47AM -0400, John Baldwin wrote: > On Thursday, May 02, 2013 4:00:11 pm Konstantin Belousov wrote: > > Author: kib > > Date: Thu May 2 20:00:11 2013 > > New Revision: 250193 > > URL: http://svnweb.freebsd.org/changeset/base/250193 > >=20 > > Log: > > The fsync(2) call should sync the vnode in such way that even after > > system crash which happen after successfull fsync() return, the data > > is accessible. For msdosfs, this means that FAT entries for the file > > must be written. > > =20 > > Since we do not track the FAT blocks containing entries for the > > current file, just do a sloppy sync of the devvp vnode for the mount, > > which buffers, among other things, contain FAT blocks. =2E.. > Does this fix kern/62762? >=20 Supposedly yes, I even possibly have seen this PR before. At least, it is understandable why do you remember about it now. I definitely do not want to take the approach of precisely calculating the list of FAT blocks which needs to be synced. --4YkaNtrv9TjfxRWe Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRhB+cAAoJEJDCuSvBvK1BvD8P/Rww9IT+1xhgWqaLRdEix/TW LtOU7gVduHTu2u0V7IQ1I7Eh8sa12+TgGGAM5a48oe9HoZrefMRDXiOZyJtuXTkR UZWDvTMS8XbDMH7jBpkr7KPwwMLls4ab/9FZ2aj2yi0FaYm6YfwKi0bglw4LsxOt sOvafc34kw3WhKgGAeaoagVUXRyHIrC6JbkjolSi/dE44pwpjd13/WacSE4ZXBAj 7nk3+koUCrSDoGyJePHvYNr5u8wE+5LPYrGpL5HG3XA+35G2wiAcVv0DSM+HmxXf C8d2se7IGwkWmOwqyxLBYdGXYAtf2M6VlgYwMK7kC/siprV7OhAJ/MN5i2FYVShZ JcN6IkacgqKzC2ER38I4FYrYrXYGvpu9bkxXbLpAwwccnaWMIkyMWkMqChZOPDvJ OI0XTOEHv+8xJGdDyJQnLr2i6lj86L6BBKyx3rL9c6BLppvJRfmxgu3A09W7vQh9 MSGgISgdFMHNHqlN7UD7EOS8lpQPmErTyPp34/7rpRCYGnynWOjzWSA9GS2kuqi8 wB8p+UywJ9RS9Hgq3kYSb202/4s7MfgQQs91ePLuPEg1oH2OCZsU049lBOw/gvJI LdTklxD8qEwQEmyoNHh5exFYcCupbpAvTC30LD3kx79DXDfSa2w9hEakKmazrsvu XmhdIpQ4havDnFuXao3Q =RkOO -----END PGP SIGNATURE----- --4YkaNtrv9TjfxRWe--