Date: Thu, 3 Nov 2011 02:30:47 +0400 (MSK) From: Dmitry Marakasov <amdmi3@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/162260: [bsd.gnome.mk] don't add useless dependency for INSTALLS_ICONS Message-ID: <20111102223047.BC0A9B846@hades.panopticon> Resent-Message-ID: <201111022240.pA2Me8Tt059415@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 162260 >Category: ports >Synopsis: [bsd.gnome.mk] don't add useless dependency for INSTALLS_ICONS >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Nov 02 22:40:08 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Dmitry Marakasov >Release: FreeBSD 8.2-RELEASE i386 >Organization: >Environment: System: FreeBSD hades.panopticon 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Tue Mar 8 09:48:52 MSK 2011 root@hades.panopticon:/async/obj/usr/src/sys/HADES i386 >Description: There is INSTALLS_ICONS knob which runs gtk-update-icon-cache when its present to update gtk icon cache. Though there are "|| /usr/bin/true" guards which make gtk-update-icon-cache commands to always succeed, there explicit dependency on gtk-update-icon-cache is still added when INSTALLS_ICONS is present, though it's completely unneeded. The patch removes it. >How-To-Repeat: >Fix: --- bsd.gnome.mk.patch begins here --- Index: bsd.gnome.mk =================================================================== RCS file: /home/amdmi3/projects/freebsd/FreeBSD.cvs/ports/Mk/bsd.gnome.mk,v retrieving revision 1.173 diff -u -r1.173 bsd.gnome.mk --- bsd.gnome.mk 12 Aug 2011 08:03:18 -0000 1.173 +++ bsd.gnome.mk 2 Nov 2011 22:26:05 -0000 @@ -557,10 +557,6 @@ . endif .endif -.if defined(INSTALLS_ICONS) -USE_GNOME+= gtk-update-icon-cache -.endif - # End component definition section # This section defines tests for optional software. These work off four --- bsd.gnome.mk.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111102223047.BC0A9B846>