From owner-freebsd-current@FreeBSD.ORG  Sun Jun 21 16:23:26 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A9C321065670;
	Sun, 21 Jun 2009 16:23:26 +0000 (UTC)
	(envelope-from gary.jennejohn@freenet.de)
Received: from mout3.freenet.de (mout3.freenet.de [IPv6:2001:748:100:40::2:5])
	by mx1.freebsd.org (Postfix) with ESMTP id 44C5D8FC17;
	Sun, 21 Jun 2009 16:23:26 +0000 (UTC)
	(envelope-from gary.jennejohn@freenet.de)
Received: from [195.4.92.22] (helo=12.mx.freenet.de)
	by mout3.freenet.de with esmtpa (ID gary.jennejohn@freenet.de) (port
	25) (Exim 4.69 #88)
	id 1MIPpE-0007a4-WD; Sun, 21 Jun 2009 18:23:24 +0200
Received: from t836d.t.pppool.de ([89.55.131.109]:14614
	helo=ernst.jennejohn.org)
	by 12.mx.freenet.de with esmtpa (ID gary.jennejohn@freenet.de) (port
	25) (Exim 4.69 #79)
	id 1MIPpE-0007Xs-Mn; Sun, 21 Jun 2009 18:23:24 +0200
Date: Sun, 21 Jun 2009 18:23:23 +0200
From: Gary Jennejohn <gary.jennejohn@freenet.de>
To: Roman Divacky <rdivacky@freebsd.org>
Message-ID: <20090621182323.5eb46969@ernst.jennejohn.org>
In-Reply-To: <20090621082022.GA88526@freebsd.org>
References: <20090621082022.GA88526@freebsd.org>
X-Mailer: Claws Mail 3.7.1 (GTK+ 2.16.2; amd64-portbld-freebsd8.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: current@freebsd.org
Subject: Re: [PATCH]: if (cond); foo() in firewire
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: gary.jennejohn@freenet.de
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jun 2009 16:23:26 -0000

On Sun, 21 Jun 2009 10:20:22 +0200
Roman Divacky <rdivacky@freebsd.org> wrote:

> hi
> 
> is this patch correct? may I commit it?
> 
> Index: ../../../dev/firewire/fwdev.c
> ===================================================================
> --- ../../../dev/firewire/fwdev.c       (revision 194573)
> +++ ../../../dev/firewire/fwdev.c       (working copy)
> @@ -443,7 +443,7 @@
>         xfer->send.pay_len = uio->uio_resid;
>         if (uio->uio_resid > 0) {
>                 if ((err = uiomove((caddr_t)&xfer->send.payload[0],
> -                   uio->uio_resid, uio)));
> +                   uio->uio_resid, uio)))
>                         goto out;
>         }
>  
> 
> another bug found by the "useless warnings in clang" ;)
> 

Certainly looks like it should be corrected.  I'd say go ahead
and commit it in my guise as a former src-committer :)

---
Gary Jennejohn