From owner-freebsd-current@FreeBSD.ORG Sun Sep 7 21:08:07 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from hub.FreeBSD.org (hub.freebsd.org [IPv6:2001:1900:2254:206c::16:88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4F656E3C; Sun, 7 Sep 2014 21:08:07 +0000 (UTC) Date: Sun, 7 Sep 2014 17:08:02 -0400 From: Glen Barber To: sbruno@freebsd.org Subject: Re: NO INET6 warning Message-ID: <20140907210802.GA48287@hub.FreeBSD.org> References: <1410123815.10027.18.camel@bruno> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6" Content-Disposition: inline In-Reply-To: <1410123815.10027.18.camel@bruno> X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2014 21:08:08 -0000 --y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 07, 2014 at 02:03:35PM -0700, Sean Bruno wrote: > make[4]: "/home/sbruno/bsd/fbsd_head/sys/modules/if_gif/Makefile" line > 12: warning: Couldn't read shell's output for > "cat /home/sbruno/bsd/obj/mips/mips.mips/home/sbruno/bsd/fbsd_head/sys/WZ= R-300HP/opt_inet6.h" >=20 >=20 > Shouldn't this cat be done in a saner way? >=20 This is done quite often throughout the tree, and bmake(1) does not like it when there is no value assigned from the '!=3D' expansion. The fix I've seen most commonly done is to echo a newline after the assignment, such as: Index: sys/modules/if_gif/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/modules/if_gif/Makefile (revision 271215) +++ sys/modules/if_gif/Makefile (working copy) @@ -9,7 +9,7 @@ KMOD=3D if_gif SRCS=3D if_gif.c in_gif.c opt_inet.h opt_inet6.h opt_mrouting.h =20 .if defined(KERNBUILDDIR) -OPT_INET6!=3D cat ${KERNBUILDDIR}/opt_inet6.h +OPT_INET6!=3D cat ${KERNBUILDDIR}/opt_inet6.h; echo .if empty(OPT_INET6) MK_INET6_SUPPORT=3Dno .endif Glen --y0ulUmNC+osPPQO6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJUDMkyAAoJELls3eqvi17QyoAP/RnZ0kL8xEokW1Nr1D39CRQp Z8Ncjlh1dpbZhgvcYjO2Yfg4e6MZO170QTggh3qu6KoXio5CvJKzFUVjbMm4TP+Z yDnhqTNIZzRVLo4eQgDSaUckZWmJNlEaKeRKNfBur/fpfHT1klryOF/99mP+Jlck Kko9EG/9E+Rt4ZiHd3S5UQmrrt9crfaHIoT7F2zU3t3rH1S8VYo7RmbaKupxQY9n RSFii69up7QDJ1vj9J/V0436lX1aUJ8P9gTsN8r3nSkrf6OYzJEugfgWsCNKlao7 eTz933S7xyjZ8LRndqtkw/Ls7pz3biNsbpv5efKvO0ys2kQ2FVOeu35H6O4q4wNi ZvSPoeIAFcr5fYHXfXXVY8xZ6sFcoyXSl8yxXMjkGjothRV7r0SUvwXFSTHcqdvo aviyekvmJmfLJx5Y9rUv04CeeQwuxmxNLmpv0nTXKinjFu1MVUy869XN6c0EsHME Djio7vuVd2XbL3go33qPZ5QCV1yhdVyouauHB/rkMava5u9FZYlI0vSF3wQYc2Qh chWL+ynk7rQQhmW+AyhgrqjJsG2xBjijdmVf6OCutnlDuniY16/jqEIQcBBNouO6 RyKT0E6YjMZvSefUX1+pLhkNN6DaWp7V9Ckzx6VNGRFrgR7v/K8GZucYjjYqjdOy ew/LUFxbMlaexjGOE+eT =iDh7 -----END PGP SIGNATURE----- --y0ulUmNC+osPPQO6--