From owner-svn-src-all@FreeBSD.ORG Tue Nov 18 22:00:34 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 79E9E193; Tue, 18 Nov 2014 22:00:34 +0000 (UTC) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 34402A83; Tue, 18 Nov 2014 22:00:34 +0000 (UTC) Received: from slw by zxy.spb.ru with local (Exim 4.82 (FreeBSD)) (envelope-from ) id 1Xqqp4-0008KB-Pv; Wed, 19 Nov 2014 02:00:30 +0400 Date: Wed, 19 Nov 2014 02:00:30 +0400 From: Slawa Olhovchenkov To: Xin LI Subject: Re: svn commit: r274673 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <20141118220030.GA31347@zxy.spb.ru> References: <201411181840.sAIIe2C7094558@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201411181840.sAIIe2C7094558@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Nov 2014 22:00:34 -0000 On Tue, Nov 18, 2014 at 06:40:02PM +0000, Xin LI wrote: > Author: delphij > Date: Tue Nov 18 18:40:01 2014 > New Revision: 274673 > URL: https://svnweb.freebsd.org/changeset/base/274673 > > Log: > Allow tuning zfs_max_recordsize via loader tunable. Tuning is NOT > recommended. This is not tuning, this is simple guard. And can be safe changed (incrased, at the least) in any time. For some workload optimal is maximum, i.e. 16MB. May be better comment: increasing this value required strong understaning after-effects of increasing memory consumption and bulk data transfers. (sorry for english) > Requested by: Slawa Olhovchenkov > MFC after: 2 weeks Thanks, can you allow RW? > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c > > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c > ============================================================================== > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c Tue Nov 18 18:03:40 2014 (r274672) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c Tue Nov 18 18:40:01 2014 (r274673) > @@ -51,6 +51,8 @@ > #include > #include > > +SYSCTL_DECL(_vfs_zfs); > + > /* > * The SPA supports block sizes up to 16MB. However, very large blocks > * can have an impact on i/o latency (e.g. tying up a spinning disk for > @@ -61,6 +63,9 @@ > * of this setting. > */ > int zfs_max_recordsize = 1 * 1024 * 1024; > +SYSCTL_INT(_vfs_zfs, OID_AUTO, max_recordsize, CTLFLAG_RDTUN, > + &zfs_max_recordsize, 0, > + "Maximum block size. Expect dragons when tuning this."); > > #define SWITCH64(x, y) \ > { \ > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"