From owner-svn-ports-all@freebsd.org  Tue Mar 29 08:00:01 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1C23AE1A78;
 Tue, 29 Mar 2016 08:00:01 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id A7B8210A3;
 Tue, 29 Mar 2016 08:00:01 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id A5F6F1C72; Tue, 29 Mar 2016 08:00:01 +0000 (UTC)
Date: Tue, 29 Mar 2016 08:00:01 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: marino@freebsd.org
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r412019 - head/games/tbe
Message-ID: <20160329080001.GA81193@FreeBSD.org>
References: <201603272245.u2RMjdZS009225@repo.freebsd.org>
 <20160329073339.GA72433@FreeBSD.org>
 <e5e99f807d75f25f74da3e4ce0e75613@secure.marino.st>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e5e99f807d75f25f74da3e4ce0e75613@secure.marino.st>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Mar 2016 08:00:01 -0000

On Tue, Mar 29, 2016 at 09:42:23AM +0200, John Marino (FreeBSD) wrote:
> On 3/29/2016 9:33 AM, Alexey Dokuchaev wrote:
> > On Sun, Mar 27, 2016 at 10:45:39PM +0000, John Marino wrote:
> >> New Revision: 412019
> >> URL: https://svnweb.freebsd.org/changeset/ports/412019
> >> 
> >> Log:
> >>    games/tbe: Fix plist (main executable wasn't listed)
> >>    [...]
> >> 
> >> Added:
> >>    head/games/tbe/pkg-plist   (contents, props changed)
> > 
> > I guess pkg-plist should've been repocopied (resurrected) in this case.
> 
> I disagree.
> 1) It's been gone a long time and many versions have changed since.
> Showing changes from back then to now has no value.

I thought that perhaps the won't be too many differences between that old
version amd current.

> 2) Repocopy makes sense to me ONCE, when creating a new port.  After the
> port is created, don't use it within a port.  I don't see people doing
> this and I'm glad about that.  If we said it's okay returning pkg-plist,
> then you can claim it's okay for returning patch files, which is absurd.

That seems arguable; I would consider repocopying even patches if changes
warrant it, and would certainly repocopy any pkg-* files.  It really helps
to keep the dots connected and makes archaeology much easier.  Once you
get into the habit of studying the history before making any changes on a
port this becomes quite conspicuous.

./danfe