From owner-svn-src-head@FreeBSD.ORG  Fri Aug 24 12:36:26 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E182B106564A;
	Fri, 24 Aug 2012 12:36:26 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id B75068FC0A;
	Fri, 24 Aug 2012 12:36:26 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 1100EB95D;
	Fri, 24 Aug 2012 08:36:26 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Warner Losh <imp@freebsd.org>
Date: Fri, 24 Aug 2012 08:30:46 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p17; KDE/4.5.5; amd64; ; )
References: <201208232131.q7NLVqm6098185@svn.freebsd.org>
In-Reply-To: <201208232131.q7NLVqm6098185@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201208240830.46202.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Fri, 24 Aug 2012 08:36:26 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r239623 - head/sys/arm/at91
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Aug 2012 12:36:27 -0000

On Thursday, August 23, 2012 5:31:52 pm Warner Losh wrote:
> Author: imp
> Date: Thu Aug 23 21:31:52 2012
> New Revision: 239623
> URL: http://svn.freebsd.org/changeset/base/239623
> 
> Log:
>   Use proper resource type when freeing.
>   
>   Submitted by:	Ian Lapore (indirectly in a larger patch)
> 
> Modified:
>   head/sys/arm/at91/at91_mci.c
> 
> Modified: head/sys/arm/at91/at91_mci.c
> 
==============================================================================
> --- head/sys/arm/at91/at91_mci.c	Thu Aug 23 19:40:28 2012	(r239622)
> +++ head/sys/arm/at91/at91_mci.c	Thu Aug 23 21:31:52 2012	(r239623)
> @@ -299,7 +299,7 @@ at91_mci_deactivate(device_t dev)
>  	sc->intrhand = 0;
>  	bus_generic_detach(sc->dev);
>  	if (sc->mem_res)
> -		bus_release_resource(dev, SYS_RES_IOPORT,
> +		bus_release_resource(dev, SYS_RES_MEMORY,
>  		    rman_get_rid(sc->mem_res), sc->mem_res);

If I had my way, it would just be 'bus_release_resource(dev, sc->mem_res);'.
There's no good reason the resource can't store its rid and type internally.

-- 
John Baldwin