From owner-svn-src-all@freebsd.org Tue Jun 5 02:08:09 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69E83FDBBB7 for ; Tue, 5 Jun 2018 02:08:09 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EC62176563 for ; Tue, 5 Jun 2018 02:08:08 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: 4579221a-6865-11e8-8837-614b7c574d04 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id 4579221a-6865-11e8-8837-614b7c574d04; Tue, 05 Jun 2018 02:08:00 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w5527x23036281; Mon, 4 Jun 2018 20:07:59 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1528164479.32688.223.camel@freebsd.org> Subject: Re: svn commit: r334630 - head/usr.bin/indent From: Ian Lepore To: rgrimes@freebsd.org, Piotr Pawel Stefaniak Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Mon, 04 Jun 2018 20:07:59 -0600 In-Reply-To: <201806050000.w5500Men098070@pdx.rh.CN85.dnsmgr.net> References: <201806050000.w5500Men098070@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 02:08:09 -0000 On Mon, 2018-06-04 at 17:00 -0700, Rodney W. Grimes wrote: > > > > Author: pstef > > Date: Mon Jun  4 20:24:31 2018 > > New Revision: 334630 > > URL: https://svnweb.freebsd.org/changeset/base/334630 > > > > Log: > >   indent(1): remove static const char copyright[] > >    > >   It repeats what is already said in the heading comment and it's optimized out > >   so serves no purpose. > The purpose would be to put a copyright into the binary, and why that is not > happening when the original authors intended that is not good. > > This is a regression, as 5.4p8 shows: > {108}% strings /usr/bin/indent | grep -i copy > bcopy > @(#) Copyright (c) 1985 Sun Microsystems, Inc. > @(#) Copyright (c) 1976 Board of Trustees of the University of Illinois. > @(#) Copyright (c) 1980, 1993 > > Please walk very very very carefully around all things "copyright". > Does it matter what the original author intended? Nothing in the license text itself requires that copyright info be included in the binary (it just has to be in the docs and accompanying materials). So why would an edit to remove that from the binary be any different than any other edit to the code that any committer chooses to make? -- Ian