From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 12 02:40:23 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F58E16A4CE for ; Sun, 12 Sep 2004 02:40:23 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3411843D45 for ; Sun, 12 Sep 2004 02:40:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8C2eNU9086918 for ; Sun, 12 Sep 2004 02:40:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8C2eNfA086917; Sun, 12 Sep 2004 02:40:23 GMT (envelope-from gnats) Resent-Date: Sun, 12 Sep 2004 02:40:23 GMT Resent-Message-Id: <200409120240.i8C2eNfA086917@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8F05216A4CE for ; Sun, 12 Sep 2004 02:37:29 +0000 (GMT) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5DA0C43D31 for ; Sun, 12 Sep 2004 02:37:28 +0000 (GMT) (envelope-from dan@obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8C2bQqQ007091 for ; Sun, 12 Sep 2004 04:37:27 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8C2bQis007090 for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 04:37:26 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <200409120237.i8C2bQis007090@kulesh.obluda.cz> Date: Sun, 12 Sep 2004 04:37:26 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/71615: [PATCH] cleanup of the usr.sbin/usbd code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 02:40:23 -0000 >Number: 71615 >Category: bin >Synopsis: [PATCH] cleanup of the usr.sbin/usbd code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 02:40:22 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386 $FreeBSD: src/usr.sbin/usbd/usbd.c,v 1.29 2003/10/25 22:03:10 jmg >Description: There are more than 5000 warnings issued during "make buildworld". Some of them are false positives, but some of them are sign of true errors. Nobody is upset by warnings due it's amount, so some errors remain uncorrected. I want to cleanup the code-base from warnings, so warnings will become "attention mark" again. usr.sbin/usbd/usbd.c:588: warning: long int format, time_t arg (arg 2) usr.sbin/usbd/usbd.c:610: warning: int format, pointer arg (arg 2) usr.sbin/usbd/usbd.c:615: warning: unsigned int format, pointer arg (arg 2) usr.sbin/usbd/usbd.c:615: warning: char format, different type arg (arg 3) >How-To-Repeat: N/A >Fix: *** usr.sbin/usbd/usbd.c.ORIG Sun Sep 5 18:40:34 2004 --- usr.sbin/usbd/usbd.c Sun Sep 5 18:51:23 2004 *************** *** 584,590 **** devinfo = &event->u.ue_device; printf(" at %ld.%09ld, %s, %s:\n", ! timespec->tv_sec, timespec->tv_nsec, devinfo->udi_product, devinfo->udi_vendor); printf(" vndr=0x%04x prdct=0x%04x rlse=0x%04x " --- 584,590 ---- devinfo = &event->u.ue_device; printf(" at %ld.%09ld, %s, %s:\n", ! (long int)timespec->tv_sec, timespec->tv_nsec, devinfo->udi_product, devinfo->udi_vendor); printf(" vndr=0x%04x prdct=0x%04x rlse=0x%04x " *************** *** 607,618 **** } } else if (event->ue_type == USB_EVENT_CTRLR_ATTACH || event->ue_type == USB_EVENT_CTRLR_DETACH) { ! printf(" bus=%d", &event->u.ue_ctrlr.ue_bus); } else if (event->ue_type == USB_EVENT_DRIVER_ATTACH || event->ue_type == USB_EVENT_DRIVER_DETACH) { printf(" cookie=%u devname=%s", ! &event->u.ue_driver.ue_cookie.cookie, ! &event->u.ue_driver.ue_devname); } printf("\n"); } --- 607,618 ---- } } else if (event->ue_type == USB_EVENT_CTRLR_ATTACH || event->ue_type == USB_EVENT_CTRLR_DETACH) { ! printf(" bus=%d", event->u.ue_ctrlr.ue_bus); } else if (event->ue_type == USB_EVENT_DRIVER_ATTACH || event->ue_type == USB_EVENT_DRIVER_DETACH) { printf(" cookie=%u devname=%s", ! event->u.ue_driver.ue_cookie.cookie, ! event->u.ue_driver.ue_devname); } printf("\n"); } >Release-Note: >Audit-Trail: >Unformatted: