From nobody Wed May 27 15:33:38 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gQYYZ3w9sz6fCtC for ; Wed, 27 May 2026 15:33:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gQYYZ2pKTz3Xbj for ; Wed, 27 May 2026 15:33:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779896018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ShXiKXK8Wj4rj+cIc5r5/m/0ffFfza5X3HaG26ziy8k=; b=sSvpGBV0Cl8intZ88reyHRe+Esw0wP3np5RBnM5tLVL0AsAGLR5QU6Xq/0VuQ7vzWu1Wu3 rMqWfY59oqFK+ZsOXbdzPwHd2oYdlAtmvmq1RLhjv1Fa9CrxxT0D6GDpdJhQkHPmBhL5UP /Nzdz+Gr7CbYrE+oTKxYJiG98YElJhWiiXPumeqRvFLmUpMLazwzd5+xdYUytFQmtRBtL5 w7BVZe4YAbmVBLqzQu3DLRY0wsm9c5xio0fgDI3+qHSxib5uxJyQw3Ywao+KPpxFJG/YVm mwKenCLXZip9N2v4K6vbYsG2RuUtjTiBxUm4gkzrVRL0e+9Z27RofDPCmh0BcA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779896018; a=rsa-sha256; cv=none; b=tcFQ7O2MQIb981WZ9/TfiklgA63xyNUeD+U73mGb2+YrHk9oUzuekVFz2ss0MwhvOGFKZO s38Ch3ZPDUbubfUNQJ7O2UD2iN1AsUPUJ6ckouM6fbYKiHYV7rT/DaMUJpwd2CDZRkCEHW csqfp94QMUnVBLi+VpbUdPP78SDfKgu46GaRGz16oKVHf80SCLbtu+Br0QUBMtHv25dKrs LBPAmbpb1m5OkxUNhDkVh21sfs5gMhaEXnDzvZ3ymyZu3Jcl7y9Wpgrh7jvqGSUYbjwYTT w2Bpnzh+ZJvQjIaLu8weTDSaQ813SJQAyoONyCYu2fUnAoJfGhAUSp6tinkjVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779896018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ShXiKXK8Wj4rj+cIc5r5/m/0ffFfza5X3HaG26ziy8k=; b=A0I63T//orLykveKWnIeT2H552dYozs6Ffgu+uz0fQmvavYcjgWPz3SdsENIhP/TDanc05 RntVzdbEXMYsNvSB5u3dtGnHg6nUTaxfdtiSckB83UpZLYL7hywycGRdGh+dwr99yr3cAM QsqPkaxBeluEqqyToKUB81edjH65F6DF+jmcquBKiNoRaKnRja83P73usZC0gK3bHNt809 L/6/UNpRAZBCqjkMr2ysmf/UrZionk32Fl5WFQVM0OPYRZhWi6xKHHTbJMi2vEa3Y9DxB7 Hc88vaY9ulIOdiamRa5dWR9RpSotz5MiiWsEu/Nb3HYFR315OBqBmJNSHTH1GA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gQYYZ2DW6z14HJ for ; Wed, 27 May 2026 15:33:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 27266 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 27 May 2026 15:33:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 64ebbb1d7441 - main - sound: Retire MIXER_SIZE and use correct size in DEFINE_CLASS List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 64ebbb1d74415cb93445cc625da63449f01ac8c5 Auto-Submitted: auto-generated Date: Wed, 27 May 2026 15:33:38 +0000 Message-Id: <6a170ed2.27266.287a6f95@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=64ebbb1d74415cb93445cc625da63449f01ac8c5 commit 64ebbb1d74415cb93445cc625da63449f01ac8c5 Author: Christos Margiolis AuthorDate: 2026-04-18 10:29:39 +0000 Commit: Christos Margiolis CommitDate: 2026-05-27 15:32:12 +0000 sound: Retire MIXER_SIZE and use correct size in DEFINE_CLASS I am not sure why this hack was needed, but the size should be sizeof(struct snd_mixer). Unfortunately, we have to expose snd_mixer, but it should be better than relying on a hack. Sponsored by: The FreeBSD Foundation MFC after: 1 week Pull Request: https://ron-dev.freebsd.org/FreeBSD/src/pulls/18 --- sys/dev/sound/pcm/mixer.c | 22 ---------------------- sys/dev/sound/pcm/mixer.h | 32 ++++++++++++++++++++++++-------- 2 files changed, 24 insertions(+), 30 deletions(-) diff --git a/sys/dev/sound/pcm/mixer.c b/sys/dev/sound/pcm/mixer.c index e61371d13610..8d96486c862b 100644 --- a/sys/dev/sound/pcm/mixer.c +++ b/sys/dev/sound/pcm/mixer.c @@ -37,28 +37,6 @@ #include "feeder_if.h" #include "mixer_if.h" -#define MIXER_NAMELEN 16 -struct snd_mixer { - KOBJ_FIELDS; - void *devinfo; - int hwvol_mixer; - int hwvol_step; - int type; - device_t dev; - u_int32_t devs; - u_int32_t mutedevs; - u_int32_t recdevs; - u_int32_t recsrc; - u_int16_t level[32]; - u_int16_t level_muted[32]; - u_int8_t parent[32]; - u_int32_t child[32]; - u_int8_t realdev[32]; - char name[MIXER_NAMELEN]; - struct mtx lock; - int modify_counter; -}; - static u_int16_t snd_mixerdefaults[SOUND_MIXER_NRDEVICES] = { [SOUND_MIXER_VOLUME] = 75, [SOUND_MIXER_BASS] = 50, diff --git a/sys/dev/sound/pcm/mixer.h b/sys/dev/sound/pcm/mixer.h index b16256862b4f..34f0514c6271 100644 --- a/sys/dev/sound/pcm/mixer.h +++ b/sys/dev/sound/pcm/mixer.h @@ -30,6 +30,28 @@ #ifndef _PCM_MIXER_H_ #define _PCM_MIXER_H_ +#define MIXER_NAMELEN 16 +struct snd_mixer { + KOBJ_FIELDS; + void *devinfo; + int hwvol_mixer; + int hwvol_step; + int type; + device_t dev; + u_int32_t devs; + u_int32_t mutedevs; + u_int32_t recdevs; + u_int32_t recsrc; + u_int16_t level[32]; + u_int16_t level_muted[32]; + u_int8_t parent[32]; + u_int32_t child[32]; + u_int8_t realdev[32]; + char name[MIXER_NAMELEN]; + struct mtx lock; + int modify_counter; +}; + struct snd_mixer *mixer_create(device_t dev, kobj_class_t cls, void *devinfo, const char *desc); int mixer_delete(struct snd_mixer *m); @@ -65,13 +87,7 @@ void *mix_getdevinfo(struct snd_mixer *m); #define MIXER_TYPE_PRIMARY 0 /* mixer_init() */ #define MIXER_TYPE_SECONDARY 1 /* mixer_create() */ -/* - * this is a kludge to allow hiding of the struct snd_mixer definition - * 512 should be enough for all architectures - */ -#define MIXER_SIZE (512 + sizeof(struct kobj) + \ - sizeof(oss_mixer_enuminfo)) - -#define MIXER_DECLARE(name) static DEFINE_CLASS(name, name ## _methods, MIXER_SIZE) +#define MIXER_DECLARE(name) static DEFINE_CLASS(name, name ## _methods, \ + sizeof(struct snd_mixer)) #endif /* _PCM_MIXER_H_ */