From nobody Wed Mar 25 10:54:01 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fgkL220Wfz6W5cT for ; Wed, 25 Mar 2026 10:54:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fgkL20Wbsz3MJn for ; Wed, 25 Mar 2026 10:54:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774436042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tjm4ScYbZu/4fwfFAXGlhuHv2lck8I8u9cFLXkJEKMM=; b=vnzYCDf3OKEET6F4BtE4Me1w6ZvzpEpR3J/07Dqf4FmpagSacC843enSKWJGtjohEjzygx l/iJvStFFpvOx51sCyCV7yKxLgiwNBHf8JtdHzMpoe3Q2FG1G/pESTghNRw+yQYAmqFZxW p7+qzOzAuHEGTIIf/8rnNnKTjqSLLKHTSwXwUMOK/2dJr/j2bhyFAczJ/f0s+LdZo44Ahp efUe9WLTJ/+rhcjVE5rKXhEOHd6pYHIyQ5QXjW+9PEsuWcPKKY4it6wLY1e1XXhoEtgOaX NCEnZnEClq+hg5HQahOlxFkRiXmddubyAXHSMfAlqVfwP6Lnn47pPEcWEsvBBw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1774436042; a=rsa-sha256; cv=none; b=E3qiRsFRiZRNeva/QBqzmfREPE06lMOEJgc4Qpvx8t5CB4ncRvnlvtVkk2eH9eOo6GeHbd gvao1BFUf+/cBr5UhMkvUo+jZQCJSn/6iIrNWU++8oLEjkp/xrL4KL12b4S3jrnHrVWNKD 5LDfJBikjACXrVHb9WqvoD5EWrKQuteHuuohwLpHU8s3NX8pHmgCud7KXVq3YoEzH23EJV 2FedV6QAjUM818s83+npdrU2AFPO6Td9NsNsNOJ32HCf9pdoEydjLj6bLN68ILb8UGvaCP 1oeWRhCFlZeGxeiVfeDi3aT5O/5DM6YLms9eJ0lYoxA2d7GadnLwvfDxL7YUfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1774436042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tjm4ScYbZu/4fwfFAXGlhuHv2lck8I8u9cFLXkJEKMM=; b=bGqH0YKO6KfsVEbpDJzqxIFwFdtJfE3DplCOw0BtXyP78VDm1Dg4XoJUbnrTT9FxRoLy47 /dT1RaXU6CHbN88LEnDfDGo29UWHj8fIwJ/0iL1Eg/2WMfQ+8lTfR4ecrut1sUtI32ARPP NTBUitT8YR58+fsMiXnnpHgJGMP6niPLOKdCMjHFXiCa5vK6aQQZfCGY2AK4mg/ywuyZZb 8ArFNORPa9U28jd2R43pdq48qvwzcGP0zsX/VktkCz8+wzctps+YBkzCvZUOKihrWMnMxd Z61hITKfb3kNlJ86+2iYtaSfnH4AxA3XbPnyf1DBiyCZRt8g7ciHmElP40VWbg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fgkL1741Dz12kP for ; Wed, 25 Mar 2026 10:54:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 370b0 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 25 Mar 2026 10:54:01 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kristof Provost Subject: git: 958dbc87e9c5 - stable/14 - pf tests: verify that we handle address range rules correctly List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 958dbc87e9c59a2e9f83d84115ce03fb96e9b249 Auto-Submitted: auto-generated Date: Wed, 25 Mar 2026 10:54:01 +0000 Message-Id: <69c3bec9.370b0.52fea7da@gitrepo.freebsd.org> The branch stable/14 has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=958dbc87e9c59a2e9f83d84115ce03fb96e9b249 commit 958dbc87e9c59a2e9f83d84115ce03fb96e9b249 Author: Kristof Provost AuthorDate: 2026-03-12 14:23:32 +0000 Commit: Kristof Provost CommitDate: 2026-03-25 09:58:27 +0000 pf tests: verify that we handle address range rules correctly There's been a problem where rules which differed only in address ranges were considered duplicates and not added. Test for this. MFC after: 1 week Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit ab74151e8d097b263237942c0b12277098bc9533) --- tests/sys/netpfil/pf/pass_block.sh | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/tests/sys/netpfil/pf/pass_block.sh b/tests/sys/netpfil/pf/pass_block.sh index 792b73b4a0a5..b91ba7f9ee68 100644 --- a/tests/sys/netpfil/pf/pass_block.sh +++ b/tests/sys/netpfil/pf/pass_block.sh @@ -255,6 +255,43 @@ urpf_cleanup() pft_cleanup } +atf_test_case "addr_range" "cleanup" +addr_range_head() +{ + atf_set descr 'Test rulesets with multiple address ranges' + atf_set require.user root +} + +addr_range_body() +{ + pft_init + + epair=$(vnet_mkepair) + ifconfig ${epair}b 192.0.2.2/24 up + + vnet_mkjail alcatraz ${epair}a + jexec alcatraz ifconfig ${epair}a 192.0.2.1/24 up + + # Sanity check + atf_check -s exit:0 -o ignore ping -c 1 -t 1 192.0.2.1 + + jexec alcatraz pfctl -e + pft_set_rules alcatraz \ + "block" \ + "pass inet from any to 10.100.100.1 - 10.100.100.20" \ + "pass inet from any to 192.0.2.1 - 192.0.2.10" + +jexec alcatraz pfctl -sr -vv + + atf_check -s exit:0 -o ignore ping -c 1 -t 1 192.0.2.1 +jexec alcatraz pfctl -sr -vv +} + +addr_range_cleanup() +{ + pft_cleanup +} + atf_init_test_cases() { atf_add_test_case "v4" @@ -262,4 +299,5 @@ atf_init_test_cases() atf_add_test_case "noalias" atf_add_test_case "nested_inline" atf_add_test_case "urpf" + atf_add_test_case "addr_range" }