From owner-freebsd-bugs@FreeBSD.ORG Thu Jun 8 09:11:47 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78F9E16BCCA for ; Thu, 8 Jun 2006 07:10:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D00D43D55 for ; Thu, 8 Jun 2006 07:10:11 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k587AB4Y009370 for ; Thu, 8 Jun 2006 07:10:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k587ABou009369; Thu, 8 Jun 2006 07:10:11 GMT (envelope-from gnats) Resent-Date: Thu, 8 Jun 2006 07:10:11 GMT Resent-Message-Id: <200606080710.k587ABou009369@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Gea-Suan Lin Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD50116FD7C for ; Thu, 8 Jun 2006 04:34:17 +0000 (UTC) (envelope-from gslin@ccbsd3.csie.nctu.edu.tw) Received: from ccbsd3.csie.nctu.edu.tw (ccbsd3.csie.nctu.edu.tw [140.113.209.63]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3373143D48 for ; Thu, 8 Jun 2006 04:34:16 +0000 (GMT) (envelope-from gslin@ccbsd3.csie.nctu.edu.tw) Received: from ccbsd3.csie.nctu.edu.tw (gslin@localhost.csie.nctu.edu.tw [127.0.0.1]) by ccbsd3.csie.nctu.edu.tw (8.13.6/8.13.6) with ESMTP id k584YH5c015481; Thu, 8 Jun 2006 12:34:17 +0800 (CST) (envelope-from gslin@ccbsd3.csie.nctu.edu.tw) Received: (from gslin@localhost) by ccbsd3.csie.nctu.edu.tw (8.13.6/8.13.6/Submit) id k584YHNK015480; Thu, 8 Jun 2006 12:34:17 +0800 (CST) (envelope-from gslin) Message-Id: <200606080434.k584YHNK015480@ccbsd3.csie.nctu.edu.tw> Date: Thu, 8 Jun 2006 12:34:17 +0800 (CST) From: Gea-Suan Lin To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: gslin@csie.nctu.edu.tw Subject: bin/98693: Reduce NIS server loading X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Gea-Suan Lin List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2006 09:11:48 -0000 >Number: 98693 >Category: bin >Synopsis: Reduce NIS server loading >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jun 08 07:10:11 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Gea-Suan Lin >Release: FreeBSD 6.1-STABLE i386 >Organization: >Environment: System: FreeBSD ccbsd3.csie.nctu.edu.tw 6.1-STABLE FreeBSD 6.1-STABLE #2: Thu Jun 8 06:24:03 CST 2006 root@ccbsd3.csie.nctu.edu.tw:/usr/obj/usr/src/sys/CCBSD3 i386 >Description: If there are a lot of users (> 10k) in NIS, then running top causes NIS server high load. >How-To-Repeat: >Fix: --- /usr/src/usr.bin/top/machine.c Wed May 18 21:42:51 2005 +++ machine.c Thu Jun 8 12:32:56 2006 @@ -62,7 +62,7 @@ int swapmode(int *retavail, int *retfree); static int smpmode; enum displaymodes displaymode; -static int namelength = 8; +static int namelength = UPUNAMELEN; static int cmdlengthdelta; /* Prototypes for top internals */ @@ -235,14 +235,8 @@ modelen != sizeof(smpmode)) smpmode = 0; - while ((pw = getpwent()) != NULL) { - if (strlen(pw->pw_name) > namelength) - namelength = strlen(pw->pw_name); - } if (smpmode && namelength > SMPUNAMELEN) namelength = SMPUNAMELEN; - else if (namelength > UPUNAMELEN) - namelength = UPUNAMELEN; kd = kvm_open(NULL, _PATH_DEVNULL, NULL, O_RDONLY, "kvm_open"); if (kd == NULL) >Release-Note: >Audit-Trail: >Unformatted: