From owner-cvs-src@FreeBSD.ORG  Mon Sep 26 11:21:13 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 54C0B16A41F;
	Mon, 26 Sep 2005 11:21:13 +0000 (GMT) (envelope-from bde@zeta.org.au)
Received: from mailout2.pacific.net.au (mailout2.pacific.net.au [61.8.0.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C370643D48;
	Mon, 26 Sep 2005 11:21:12 +0000 (GMT) (envelope-from bde@zeta.org.au)
Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au
	[61.8.0.87])
	by mailout2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id
	j8QBLBsc026496; Mon, 26 Sep 2005 21:21:11 +1000
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailproxy2.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id
	j8QBLAXX001207; Mon, 26 Sep 2005 21:21:10 +1000
Date: Mon, 26 Sep 2005 21:21:10 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@delplex.bde.org
To: Robert Watson <rwatson@freebsd.org>
In-Reply-To: <200509260802.j8Q82PFW064658@repoman.freebsd.org>
Message-ID: <20050926212051.J21547@delplex.bde.org>
References: <200509260802.j8Q82PFW064658@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/kern subr_prf.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Sep 2005 11:21:13 -0000

On Mon, 26 Sep 2005, Robert Watson wrote:

> rwatson     2005-09-26 08:02:24 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/kern             subr_prf.c
>  Log:
>  Acquire Giant in uprintf() and tprintf() rather than asserting it.  In
>  the vast majority of cases, these functions are called without mutexes
>  held, meaning that in all but two cases, there will be no ordering
>  issues with doing this, and it will eliminate the need for changes in
>  the caller.  In two cases, mutexes are held, so Giant must be acquired
>  before those mutexes such that uprintf() and tprintf() recurse Giant
>  rather than generating a lock order reversal.
>
>  Suggested by:   bde

Thansks.

Bruce