From owner-freebsd-arch@FreeBSD.ORG  Mon Mar  6 11:46:00 2006
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: freebsd-arch@freebsd.org
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A3D4916A422
	for <freebsd-arch@freebsd.org>; Mon,  6 Mar 2006 11:46:00 +0000 (GMT)
	(envelope-from deischen@freebsd.org)
Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3C25943D49
	for <freebsd-arch@freebsd.org>; Mon,  6 Mar 2006 11:46:00 +0000 (GMT)
	(envelope-from deischen@freebsd.org)
Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11])
	by mail.ntplx.net (8.13.5/8.13.5/NETPLEX) with ESMTP id k26BjwuX028185; 
	Mon, 6 Mar 2006 06:45:59 -0500 (EST)
Date: Mon, 6 Mar 2006 06:45:58 -0500 (EST)
From: Daniel Eischen <deischen@freebsd.org>
X-X-Sender: eischen@sea.ntplx.net
To: Peter Wemm <peter@wemm.org>
In-Reply-To: <200603051937.35717.peter@wemm.org>
Message-ID: <Pine.GSO.4.43.0603060635040.29520-100000@sea.ntplx.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net)
Cc: freebsd-arch@freebsd.org
Subject: Re: make tools question & symbol versioning
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Daniel Eischen <deischen@freebsd.org>
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Mar 2006 11:46:00 -0000

On Sun, 5 Mar 2006, Peter Wemm wrote:

> On Tuesday 28 February 2006 07:06 am, Daniel Eischen wrote:
> > On Tue, 28 Feb 2006, Hajimu UMEMOTO wrote:
> >
> > > deischen> I'll remove gethostbyname_r.  If you find others that
> > > deischen> shouldn't be there, please let me know.
> > >
> > > Please remove the functions listed in netdb_private.h.
> >
> > Will do.
>
> These are real exported functions.  The netdb_private.h thing is a hack
> to force people to do the correct #includes.  People got tired of folks
> using ancient code with bogus manual 'extern' declarations with bogus
> structs and wondering why it didn't work correctly.
>
> I think they should be versioned, and the netdb_private.h stuff adjusted
> if necessary.

It looks like these functions:

   __endhostent_r
   __endnetent_r
   __endprotoent_r
   __endservent_r
   __gethostbyaddr_r
   __gethostbyname_r
   __gethostbyname2_r
   __gethostent_r
   __getnetbyaddr_r
   __getnetbyname_r
   __getnetent_r
   __getprotobyname_r
   __getprotobynumber_r
   __getprotoent_r
   __getservbyname_r
   __getservbyport_r
   __getservent_r
   __sethostent_r
   __setnetent_r
   __setprotoent_r
   __setservent_r

were added relatively recently (April 05) to make the library
thread-safe.  They are not in the POSIX spec, nor are they
in any of our standard headers.  Of the above, only the following
are visible/global in Solaris 8 (libsocket):

   getnetbyaddr_r
   getnetbyname_r
   getnetent_r
   getprotobyname_r
   getprotobynumber_r
   getprotoent_r
   getservbyname_r
   getservbyport_r
   getservent_r

and there are no setfoo_r() functions.

I don't think our functions are meant to be (at least yet)
visible to applications and have only been in the tree for
a year, as well as being prefixed with "__".

-- 
DE