From owner-freebsd-stable@FreeBSD.ORG Sun Oct 15 22:01:12 2006 Return-Path: X-Original-To: stable@freebsd.org Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E902416A407; Sun, 15 Oct 2006 22:01:12 +0000 (UTC) (envelope-from erikt@Update.UU.SE) Received: from Psilocybe.Update.UU.SE (Psilocybe.Update.UU.SE [130.238.19.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A69043D49; Sun, 15 Oct 2006 22:01:12 +0000 (GMT) (envelope-from erikt@Update.UU.SE) Received: by Psilocybe.Update.UU.SE (Postfix, from userid 15766) id 236A444014; Mon, 16 Oct 2006 00:01:11 +0200 (CEST) Date: Mon, 16 Oct 2006 00:01:11 +0200 From: Erik Trulsson To: Rink Springer Message-ID: <20061015220111.GA10634@Update.UU.SE> Mail-Followup-To: Rink Springer , Lin Jui-Nan Eric , stable@freebsd.org References: <47713ee10610150811w4cca315etc051e0fe14d88dab@mail.gmail.com> <20061015151924.GA50017@rink.nu> <47713ee10610150830g4dc4b747j9425d3b5194829f1@mail.gmail.com> <20061015154022.GC50017@rink.nu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061015154022.GC50017@rink.nu> User-Agent: Mutt/1.5.13 (2006-08-11) Cc: stable@freebsd.org, Lin Jui-Nan Eric Subject: Re: mountd changed? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Oct 2006 22:01:13 -0000 [Second attempt to send this, since my first seems to have been eaten by my ISP. Apologies if it appears twice.] On Sun, Oct 15, 2006 at 05:40:22PM +0200, Rink Springer wrote: > Hi, > > On Sun, Oct 15, 2006 at 11:30:23PM +0800, Lin Jui-Nan Eric wrote: > > Hi, > > > > If I revert to revision 1.81.2.4, it worked correctly. > > > > On 10/15/06, Rink Springer wrote: > > >Hi, > > > > > >Hmm, I recently changed something which might trigger this. Could you > > >back out revision 1.81.2.5 of src/usr.sbin/mountd/mountd.c and let me > > >know whether this fixed the problem? > > > > > OK, could you try the attached patch (untested) and let me know whether > it works? (it patches the 1.81.2.5 revision of mountd.c) I had the same problems, but only when trying to export directories from the root filesystem. Your patch below would not help. The following patch (very much inspired by the comment on line 1038 in mountd.c) makes things work for me: Index: mountd.c =================================================================== RCS file: /ncvs/src/usr.sbin/mountd/mountd.c,v retrieving revision 1.81.2.5 diff -u -r1.81.2.5 mountd.c --- mountd.c 14 Oct 2006 23:04:07 -0000 1.81.2.5 +++ mountd.c 15 Oct 2006 21:09:20 -0000 @@ -1911,7 +1911,7 @@ iov[5].iov_base = fsb->f_mntfromname; /* "from" */ iov[5].iov_len = strlen(fsb->f_mntfromname) + 1; - while (nmount(iov, iovlen, fsb->f_flags) < 0) { + while (nmount(iov, iovlen, fsb->f_flags & ~MNT_ROOTFS) < 0) { if (cp) *cp-- = savedc; else > --- mountd.c.org Thu Sep 21 10:07:57 2006 > +++ mountd.c Thu Sep 21 10:08:42 2006 > @@ -1912,7 +1912,7 @@ > iov[5].iov_base = fsb->f_mntfromname; /* "from" */ > iov[5].iov_len = strlen(fsb->f_mntfromname) + 1; > > - while (nmount(iov, iovlen, fsb->f_flags) < 0) { > + while (nmount(iov, iovlen, fsb->f_flags | MNT_UPDATE) < 0) { > if (cp) > *cp-- = savedc; > else -- Erik Trulsson ertr1013@student.uu.se