From owner-freebsd-net@FreeBSD.ORG Mon Apr 1 15:44:53 2013 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id ED66DE8F for ; Mon, 1 Apr 2013 15:44:53 +0000 (UTC) (envelope-from fodillemlinkarim@gmail.com) Received: from mail-ie0-x22a.google.com (mail-ie0-x22a.google.com [IPv6:2607:f8b0:4001:c03::22a]) by mx1.freebsd.org (Postfix) with ESMTP id BFB18E72 for ; Mon, 1 Apr 2013 15:44:53 +0000 (UTC) Received: by mail-ie0-f170.google.com with SMTP id c11so2476038ieb.29 for ; Mon, 01 Apr 2013 08:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=6ny1dBH7lRMiWgCENCNwuAoU+z+V8pn7rNDa1e1QkoE=; b=wFNSpez3J8N7iJQkNagCQiCj2udxGIYM52Qn7dezX2LP/RRT6IALmKueAK2JiFKzLw hoGmhQj6Ga9UeoW+HxrPwEGc3fBwo0mbRM4+jy17WaAEASMtZp+1Xl0/PHb8Ta6d118c t1qXFbG2OpdQhalW9Km1b+rKAXcdi5pjD5EAvGC29D2OpbXNngT65E22uWziCDnX3JTp mk6GuTQQxzZ+7fQlVlCltwO/RfGIoxIjZjmUiT4XTh4LrJsNJhART+qbH/tG+31Orc06 DIjHXNNoJxRDUE5PD6jowbGaEv5+PypjJwRGx3esHzxWKvvyUBiSgclPzQ/Ps89ntx30 nxtQ== X-Received: by 10.50.119.102 with SMTP id kt6mr3738705igb.12.1364831093526; Mon, 01 Apr 2013 08:44:53 -0700 (PDT) Received: from [192.168.1.73] ([208.85.112.101]) by mx.google.com with ESMTPS id a3sm5019547igq.5.2013.04.01.08.44.51 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 01 Apr 2013 08:44:51 -0700 (PDT) Message-ID: <5159AB72.1050202@gmail.com> Date: Mon, 01 Apr 2013 11:44:50 -0400 From: Karim Fodil-Lemelin User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: freebsd-net@freebsd.org Subject: Re: igb and ALTQ in 9.1-rc3 References: <1355177348.71087.YahooMailClassic@web121601.mail.ne1.yahoo.com> <50C6656E.3020601@gmail.com> <20121211075853.GU48639@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2013 15:44:54 -0000 Hi Jack, I think this would help M. Rogers case as we have done something similar here to circumvent the issue and it seems to work well. I would also add that when using ALTQ we found it much more stable to set the number of queues to 1: static int igb_num_queues = 1; Our approach consisted in keeping igb_start() defined and using igb_mq_start_locked() inside it instead of igb_start_locked(). Regards, Karim. On 28/03/2013 7:16 PM, Jack Vogel wrote: > Have been kept fairly busy with other matters, one thing I could do short > term is > change the defines in igb the way I did in the em driver so you could still > define > the older if_start entry. Right now those are based on OS version and so > you will > automatically get if_transmit, but I could change it to be IGB_LEGACY_TX or > so, > and that could be defined in the Makefile. > > Would this help? > > Jack > > > On Thu, Mar 28, 2013 at 2:31 PM, Nick Rogers wrote: > >> On Tue, Dec 11, 2012 at 1:09 AM, Jack Vogel wrote: >>> On Mon, Dec 10, 2012 at 11:58 PM, Gleb Smirnoff >> wrote: >>>> On Mon, Dec 10, 2012 at 03:31:19PM -0800, Jack Vogel wrote: >>>> J> UH, maybe asking the owner of the driver would help :) >>>> J> >>>> J> ... and no, I've never been aware of doing anything to stop >> supporting >>>> altq >>>> J> so you wouldn't see any commits. If there's something in the altq >> code >>>> or >>>> J> support (which I have nothing to do with) that caused this no-one >>>> informed >>>> J> me. >>>> >>>> Switching from if_start to if_transmit effectively disables ALTQ >> support. >>>> AFAIR, there is some magic implemented in other drivers that makes them >>>> modern (that means using if_transmit), but still capable to switch to >>>> queueing >>>> mode if SIOCADDALTQ was casted upon them. >>>> >>>> >>> Oh, hmmm, I'll look into the matter after my vacation. >>> >>> Jack >> Has there been any progress on resolving this issue? I recently ran >> into this problem upgrading my servers from 8.3 to 9.1-RELEASE and am >> wondering what the latest recommendation is. I've used ALTQ and igb >> successfully for years and it is unfortunate it no longer works. >> Appreciate any advice. >> >>> _______________________________________________ >>> freebsd-net@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/freebsd-net >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"