From owner-cvs-all Sun Feb 25 9:16: 0 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 9E9DD37B401; Sun, 25 Feb 2001 09:15:55 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id EAA19007; Mon, 26 Feb 2001 04:14:56 +1100 Date: Mon, 26 Feb 2001 04:13:37 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Jake Burkholder Cc: Peter Wemm , Jake Burkholder , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 db_trace.c exception.s machdep.c trap.c src/sys/i386/include asnames.h In-Reply-To: <20010225151234.1ADCFBACB@cr66388-a.rchrd1.on.wave.home.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sun, 25 Feb 2001, Jake Burkholder wrote: > > On Sat, 24 Feb 2001, Peter Wemm wrote: > > > > > Bruce Evans wrote: > > > Well, given that we have two, "Xsyscall" was wrong as it implies that it > > > was the "normal" one (it is not). Would you rather that Xint0x80syscall > > > be renamed to Xsyscall instead? > > > > Yes. > > > > Ok. > > My concern is that Xsyscall and syscall are very similar. I might > confuse them at 4 am. What about changing the X to something clearer > like idt_ ? I prefer short names, and wouldn't confuse them. >> [how mcount works in X*syscall] > > How does this work for traps then? They all jump to the common > alltraps label. It doesn't really work :-]. The entry point gets forgotten, much the same as for Xlcall_sycall. "MCOUNT_LABEL(btrap)" combined with not using complete labels for the entry points of the trap handlers has the (mostly unintentional) side effect of combining the tick counts for all the trap handler stubs. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message