From owner-cvs-src@FreeBSD.ORG Fri Feb 4 07:23:30 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 79FB316A4CE; Fri, 4 Feb 2005 07:23:30 +0000 (GMT) Received: from ylpvm29.prodigy.net (ylpvm29-ext.prodigy.net [207.115.57.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11E8643D3F; Fri, 4 Feb 2005 07:23:30 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.51] (adsl-64-171-186-233.dsl.snfc21.pacbell.net [64.171.186.233])j147NGh2031596; Fri, 4 Feb 2005 02:23:16 -0500 Message-ID: <420322CA.3090201@root.org> Date: Thu, 03 Feb 2005 23:22:50 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041205) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Marcel Moolenaar References: <20050204063905.8AE4716A4E9@hub.freebsd.org> <42031DC4.3000109@root.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ia64/ia64 machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2005 07:23:30 -0000 Marcel Moolenaar wrote: > > On Feb 3, 2005, at 11:01 PM, Nate Lawson wrote: > >> Marcel Moolenaar wrote: >> >>> marcel 2005-02-04 06:38:58 UTC >>> FreeBSD src repository >>> Modified files: >>> sys/ia64/ia64 machdep.c Log: >>> Include sys/bus.h before sys/cpu.h. The latter needs device_t. >>> Revision Changes Path >>> 1.195 +1 -0 src/sys/ia64/ia64/machdep.c >> >> >> Thanks, I've made similar changes to the other arches too. > > > No worries. Sorry I didn't had the time to test before committing. > > BTW, I still have a link error: > > pluto2# make > linking kernel.debug > acpi_cpu.o(.text+0x2302): In function `acpi_cpu_startup': > ../../../dev/acpica/acpi_cpu.c:757: undefined reference to `cpu_devclass' > acpi_cpu.o(.data+0x1a8): In function `acpi_cpu_probe': > ./bus_if.h:107: undefined reference to `cpu_devclass' > *** Error code 1 > > Stop in /q/6.x/src/sys/ia64/compile/PLUTO2. > > Can it be that you missed a file? No, it's something I need to fix one way or the other and had on my todo list. I'm not sure if my approach is correct -- should different drivers for the same hardware share the same devclass? I have legacy::cpu and acpi::cpu sharing the same devclass value since neither can be attached at the same time. I thought in the past there might be some advantage to this but can't remember the rationale. In any case, until I decide whether to go all the way in doing this for all archs or falling back to static devclasses, I'll fix it by making acpi's dc static. -- Nate