From owner-cvs-all Sat Aug 21 1:55:24 1999 Delivered-To: cvs-all@freebsd.org Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38]) by hub.freebsd.org (Postfix) with ESMTP id A63FE14F27; Sat, 21 Aug 1999 01:55:21 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (iras-3-41.ucdavis.edu [169.237.17.41]) by relay.nuxi.com (8.9.3/8.9.3) with ESMTP id BAA02210; Sat, 21 Aug 1999 01:53:21 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.9.3/8.9.1) id BAA58079; Sat, 21 Aug 1999 01:53:21 -0700 (PDT) (envelope-from obrien) Date: Sat, 21 Aug 1999 01:53:20 -0700 From: "David O'Brien" To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_physio.c Message-ID: <19990821015320.A58052@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <11805.935223305@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.3i In-Reply-To: ; from Brian F. Feldman on Sat, Aug 21, 1999 at 01:18:42AM -0700 X-Operating-System: FreeBSD 4.0-CURRENT Organization: The NUXI BSD group X-PGP-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Keyid: 34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > > Next we assign blockno to bp->b_blockno which is 32 bits wide, > > what happens to the upper 32 bits ? They're ignored, so the > > value of bp->b_blockno will be: 0x00000000. > > Ah, so you're checking for an overflow. Now it's clear to me, thanks :) IMHO we really should add a line comment. Someone looking at that piece of code will really wonder why you are doing the check. -- -- David (obrien@NUXI.com -or- obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message