From owner-freebsd-hackers@FreeBSD.ORG  Mon Aug  1 19:03:45 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6162E1065672;
	Mon,  1 Aug 2011 19:03:45 +0000 (UTC) (envelope-from avg@FreeBSD.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 7E3B28FC13;
	Mon,  1 Aug 2011 19:03:44 +0000 (UTC)
Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id WAA02272;
	Mon, 01 Aug 2011 22:03:42 +0300 (EEST)
	(envelope-from avg@FreeBSD.org)
Received: from localhost ([127.0.0.1])
	by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1QnxmA-000EcG-H0; Mon, 01 Aug 2011 22:03:42 +0300
Message-ID: <4E36F88C.7050404@FreeBSD.org>
Date: Mon, 01 Aug 2011 22:03:40 +0300
From: Andriy Gapon <avg@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
	rv:5.0) Gecko/20110706 Thunderbird/5.0
MIME-Version: 1.0
To: Jung-uk Kim <jkim@FreeBSD.org>
References: <201107312128.29322.lobo@bsd.com.br> <4E36B4CF.3060308@FreeBSD.org>
	<201108011223.55772.jkim@FreeBSD.org>
In-Reply-To: <201108011223.55772.jkim@FreeBSD.org>
X-Enigmail-Version: 1.2pre
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: freebsd-hackers@FreeBSD.org
Subject: Re: Phenom II 975 BE shows 0 celsius
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Aug 2011 19:03:45 -0000


[cc list trimmed]

on 01/08/2011 19:23 Jung-uk Kim said the following:
> I gave up the DiodeOffset recently because a lot of BIOSes do not set 
> any meaningful values.  Instead, I added a tunable for that.  Please 
> see the attached patch, which is also available from here:
> 
> http://people.freebsd.org/~jkim/amdtemp.diff

I haven't tried your patch yet, but already have a few comments :-)

- at least on head pci_cfgregread() is public via x86/include/pci_cfgreg.h

- I am not sure if you really need it; shouldn't pci_read_config() just work
since amdtemp attaches under pci bus?

- about erratum 319 - I feel like objecting to amdtemp_force_enable approach;
given the wide spread of AM2+ and AM3 in consumer boards, and the very important
fact that I have AM2+ and I have never observed (with my own eyes) incorrect
reading from amdtemp, and the less important fact that the output of amdtemp is
not used for anything critical (for anything at all, in fact) in the base
system, and that that would be a kind of POLA violation (which is PITA) - I
propose to just print some warning message on the affected systems; at most,
export that warning as a sysctl node

Finally, I promise to test this patch soon-ish.
Thank you for digging into this!

-- 
Andriy Gapon