From owner-svn-src-head@freebsd.org Thu Jan 5 08:45:54 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09FEBC9FFB3; Thu, 5 Jan 2017 08:45:54 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-lf0-x233.google.com (mail-lf0-x233.google.com [IPv6:2a00:1450:4010:c07::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C3421E48; Thu, 5 Jan 2017 08:45:53 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-lf0-x233.google.com with SMTP id x140so23067761lfa.3; Thu, 05 Jan 2017 00:45:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=h3VZkSrUB4Qm5xLyX6UwROHYGfm+G4tHiwqYwmkZbzA=; b=DS38uJ+DwyebDQXGFCOHoFOCpzEo08ZlvYkP2uQ3p4zpp8XoEVS6Ow/0KMWkKP3qdr /1S+/JP9rrXIEu5feWyMzzNAxklRaeRZMM4e0lFbkYTf0jRW2HU/2qoAaYHE9CCFGzV7 iMe0ncuf622/zC6ZXUN+YM3+JK4rDpbN9R/9byPkwnKUCAhaeVPikneln7Jr5pejbYeq Xabu1IGszyIrGoz3m/T7hntoq56/9vaszLmvpBUadFpzM8ZGjfgvTqraxof1adRNSmcf TJn3jFCZjf4GrVZQiRW7mNfzbt5leXROAdiTi09nZjcpi314bztAeDxtXC3H2TMknOc7 N4rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:mime-version:subject:from:in-reply-to :date:cc:content-transfer-encoding:message-id:references:to; bh=h3VZkSrUB4Qm5xLyX6UwROHYGfm+G4tHiwqYwmkZbzA=; b=AEpstoLTA8fqGOVMl+KJkf/P2Psdg/w77as5UJxo3bh5w7BjraKRFSEDc2HQLZumkH MmLWLTwmvU3j3aQvVXlRmb5vAc3JccsHvMHxcTbqxTZa7Z9olEAEoyw68Oz8o7100O0h s/qqCYZCyUIKCzohfTMkK+g4n9mUD0FnlWitnxTY5b9ZBV1Oz/jb5Wv9Cod8ruZtNjGe h5rMFkNdnkOuzy4Fzqg0vIeIxFgGDii3+Lfiw5ciuLeOhcMf2Lm56uOugKphhNkn2Xne htNPSv0IuDLwjjfzp+HxDMqhhdlGCwS7QymiPdaS/JsEsinbepHwadUanv+CoIwpbwZR bF3g== X-Gm-Message-State: AIkVDXIcxyKAAyU3rGtOatNMx2IdN81Hj+3trWKA75XJHienK6DlCQUbQUj0Otjd5fprkQ== X-Received: by 10.25.15.199 with SMTP id 68mr15706951lfp.53.1483605951336; Thu, 05 Jan 2017 00:45:51 -0800 (PST) Received: from [100.100.129.172] (apn-37-248-160-117.dynamic.gprs.plus.pl. [37.248.160.117]) by smtp.gmail.com with ESMTPSA id c66sm17789702ljd.44.2017.01.05.00.45.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2017 00:45:50 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r311283 - head/sys/cam/ctl From: =?utf-8?Q?Edward_Tomasz_Napiera=C5=82a?= X-Mailer: iPhone Mail (14C92) In-Reply-To: Date: Thu, 5 Jan 2017 09:45:49 +0100 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <7A6F3E33-8994-4DC2-9B2A-5C23E379680E@FreeBSD.org> References: <201701041250.v04Coits085210@repo.freebsd.org> To: Ryan Stone Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 08:45:54 -0000 Dnia 04.01.2017 o godz. 16:38 Ryan Stone napisa=C5=82(a)= : >> On Wed, Jan 4, 2017 at 7:50 AM, Edward Tomasz Napierala wrote: >> + refcount_release(&cs->cs_outstanding_ctl_pdus); >=20 > Shouldn't the return value of refcount_release() be checked? Not in this case. The destruction of cfumass sessions is always done in on= e specific place; everywhere else we don't care whether the reference was th= e last one or not.