From owner-freebsd-current@FreeBSD.ORG  Wed Jul 14 02:25:01 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 45B9D16A4CE
	for <current@freebsd.org>; Wed, 14 Jul 2004 02:25:01 +0000 (GMT)
Received: from smtp3.server.rpi.edu (smtp3.server.rpi.edu [128.113.2.3])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B9F8843D39
	for <current@freebsd.org>; Wed, 14 Jul 2004 02:25:00 +0000 (GMT)
	(envelope-from drosih@rpi.edu)
Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47])
	by smtp3.server.rpi.edu (8.13.0/8.13.0) with ESMTP id i6E2OwF1029919;
	Tue, 13 Jul 2004 22:24:58 -0400
Mime-Version: 1.0
X-Sender: drosih@mail.rpi.edu
Message-Id: <p0611041abd1a49199d83@[128.113.24.47]>
In-Reply-To: <20040713232214.GA9507@dhcp50.pn.xcllnt.net>
References: <26075.1089753893@critter.freebsd.dk>
 <p06110415bd1a0dedbf1c@[128.113.24.47]>
 <20040713232214.GA9507@dhcp50.pn.xcllnt.net>
Date: Tue, 13 Jul 2004 22:24:57 -0400
To: Marcel Moolenaar <marcel@xcllnt.net>
From: Garance A Drosihn <drosih@rpi.edu>
Content-Type: text/plain; charset="us-ascii" ; format="flowed"
X-Scanned-By: CanIt (www . canit . ca)
cc: Barney Wolff <barney@databus.com>
cc: Poul-Henning Kamp <phk@phk.freebsd.dk>
cc: current@freebsd.org
Subject: Re: CVSUP and 5.2.1 RELEASE
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jul 2004 02:25:01 -0000

At 4:22 PM -0700 7/13/04, Marcel Moolenaar wrote:
>On Tue, Jul 13, 2004 at 06:23:38PM -0400, Garance A Drosihn wrote:
>>
>>  a) how about if we print a warning and exit if DESTDIR is
>>     not defined?  Are there "important" uses of `make world'
>>     which do not use DESTDIR?
>
>My thoughts exactly. See attached patch.

Actually, the target should end with some kind of failure, in
case someone has a script that does:
      make world && do-next-thing

if we change `make world' to do nothing, then sequences like
this should error-out right away.  So I think it should have
a "false" command after all the @echo's...

-- 
Garance Alistair Drosehn            =   gad@gilead.netel.rpi.edu
Senior Systems Programmer           or  gad@freebsd.org
Rensselaer Polytechnic Institute    or  drosih@rpi.edu