From owner-svn-src-head@freebsd.org Thu Mar 17 04:46:19 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 50685AD2D74; Thu, 17 Mar 2016 04:46:19 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0135.outbound.protection.outlook.com [207.46.100.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F5CA6BE; Thu, 17 Mar 2016 04:46:17 +0000 (UTC) (envelope-from sjg@juniper.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=junipernetworks.onmicrosoft.com; s=selector1-juniper-net; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+dG63z3XjCsiRtBAOSn7K0CpKWWwN/9/O06r3w9uqOE=; b=blq/bc+veSjiT3Wj5vPwPm2ALhiMnyPyIGL+Q+HDK8oX61dV59u6YyhYRfNMIa29PqQRNQgZKzSQHftV01iuhFHndbd8SDUayBk9xyvu5iK6Mjq1lvBch9F16qfEa8+y2PdI1FnCSkojUN8bb2L4/o7SZRM5vV0JDx/kWvaDO3s= Received: from SN1PR0501CA0016.namprd05.prod.outlook.com (10.163.126.154) by CY1PR0501MB1161.namprd05.prod.outlook.com (10.160.144.155) with Microsoft SMTP Server (TLS) id 15.1.434.16; Thu, 17 Mar 2016 04:30:43 +0000 Received: from BL2FFO11FD027.protection.gbl (2a01:111:f400:7c09::180) by SN1PR0501CA0016.outlook.office365.com (2a01:111:e400:52fe::26) with Microsoft SMTP Server (TLS) id 15.1.443.12 via Frontend Transport; Thu, 17 Mar 2016 04:30:42 +0000 Authentication-Results: spf=softfail (sender IP is 66.129.239.19) smtp.mailfrom=juniper.net; freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=juniper.net; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.19 as permitted sender) Received: from p-emfe01b-sac.jnpr.net (66.129.239.19) by BL2FFO11FD027.mail.protection.outlook.com (10.173.161.106) with Microsoft SMTP Server (TLS) id 15.1.434.11 via Frontend Transport; Thu, 17 Mar 2016 04:30:41 +0000 Received: from magenta.juniper.net (172.17.27.123) by p-emfe01b-sac.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.123.3; Wed, 16 Mar 2016 21:30:40 -0700 Received: from kaos.jnpr.net (kaos.jnpr.net [172.21.16.84]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id u2H4UdD95809; Wed, 16 Mar 2016 21:30:39 -0700 (PDT) (envelope-from sjg@juniper.net) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id A5A94385532; Wed, 16 Mar 2016 21:30:39 -0700 (PDT) To: Bryan Drewery CC: NGie Cooper , , , , Subject: Re: svn commit: r296970 - head/lib/libxo/tests In-Reply-To: <56EA2E93.2020406@FreeBSD.org> References: <201603170037.u2H0b4Rb082849@repo.freebsd.org> <984878F0-9CE9-442D-8F7F-40C5365052AA@gmail.com> <85789.1458187497@kaos.jnpr.net> <56EA2E93.2020406@FreeBSD.org> Comments: In-reply-to: Bryan Drewery message dated "Wed, 16 Mar 2016 21:12:03 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6; nmh 1.6; GNU Emacs 24.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <86202.1458189039.1@kaos.jnpr.net> Date: Wed, 16 Mar 2016 21:30:39 -0700 Message-ID: <86203.1458189039@kaos.jnpr.net> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:66.129.239.19; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(189002)(199003)(24454002)(11100500001)(4326007)(2906002)(1096002)(87936001)(6806005)(50986999)(1220700001)(2810700001)(5008740100001)(76176999)(46406003)(86362001)(76506005)(586003)(53416004)(97756001)(106466001)(23726003)(47776003)(105596002)(81166005)(117636001)(107886002)(110136002)(189998001)(77096005)(2950100001)(93886004)(92566002)(4001430100002)(19580405001)(50226001)(50466002)(19580395003)(5003600100002)(42262002); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0501MB1161; H:p-emfe01b-sac.jnpr.net; FPR:; SPF:SoftFail; MLV:sfv; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD027; 1:xU6OEnUo8YT22ZQSO0x1t1aFDkYHm7rB/u7lbQpHMdKRW/ZsuFfLVWOayiTGLQfWPWDNwuC1N/QVN+rAadS+UFkwzCXH7ifDXwf4cgnA94n94qGWZzy2/5vrrhmsKxt+z0FmwPqRmqd9IHVtcy5Wd7x/xgl0UZevdB+JFuQ3MKZzh5lvqmvzdGsNVgDP8RRRNiqQnTq3nDIBXqSyw/cc/0XoKlmp/bnfNys88+al6O69QGUmWHrwojACAgGbvfe7xAjRBiCAIucLDZVmO7MdN29M1gZmjDB0+pWUVMA0S6IQh+nHc1IdWuyx0Md4T4VY1m191RWtJcdtX2F60zYUtlWm23HU7eQis7lSGFXzMmStF3rSuHKIybTcgH6pH1X3fFMRbhGZv1cr4mTVMIsWWk3DXEnl0HH3w43dz08o47N6an8rZnIZ28wsBejyFUDN X-MS-Office365-Filtering-Correlation-Id: d1a1c061-4412-414e-c9d6-08d34e1ce6b1 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0501MB1161; 2:wn9mEtmbmUOx7bGydCAjXjjfRM+lJvhgaP2+03W9ZekiPY6b4GPgn/OIXOIODUyVHbgCQb5e2LX838wsw7hdRo5RUWeFqm1sZXQ5Ce1zt9FjrfkPYefe/0p7gjxfctREa0xid4sGkHDQA9+Hj61LoHLSML2JuddOQJeyn7a7rrhWIg6Ln9nhtAHdxkbHPo6a; 3:Go3hNwcSi0Eljz0Wx+VkQz87Xp5xS5l6NVFpBETmDZ6gm9HvfCOA5CqMjrxz7InqgZf5gG7OyfZcxCp+bZpMyw42JKvDqLxq3LWxK1KZM+VrM6/fANP3zdSHkFT6VslSRhUJp9ob6kPB1pqRt19FJWQ5YlT3UkdSpNgOLrvLYlS5ckDKA9OQ9pOu66xSPWSsuzc9MeXSD3LdfLEGpyoRhIgMANPYNhdyWxFlqo5FiVU=; 25:l6J++EkHM+8JOM6SJkFhkezAtJ7H1izyIoof1YlwTjhSvPtkM1XNcr4Qvp9G88riJyHCsrLaGZ54UzmwDRPtQnKZkJphf2U6egnlAvUF3g1S1LuVMX3duSHUeW1QZLkVAcuBn8Bq0ae6TNoiCReVOS4ea1SxxpcDoU9k93ppszV+Fa7vZAcEvnXiAB/2tWVCBwc+9Wsd8jHLOWWSAlU4746w3XQ5szQv84JbF9xHE2UpnE1NKCba0S/TyEqLMqjJvd3QSeV0Sy418xUwNM3iUjGZpyq3FHn0X6LOWyAuj9XeKc4WBrt8pHy9MdvGpxRc X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0501MB1161; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0501MB1161; 20:hvfy2dzTHEToo7DRHI1JqipcPQORUdnG7DW1ZKtZ68as1gqcaOoRbGpcljcvawygvLYIeIPBOGAlw7x9nwyy+KCdeeiwEA2lR127YLORbXUB7dLTaNvhIH3pgD1rJ6Qh9WufN4hDQG8iyMXokY3MKqedSNd0sV5prnVqx+ws2r9+ZaZxQrtiZ92sEF8PNMBXOmZMG0R3yqKLC36wdtD29QrSB6C9O6DaSEUokJ73HhwZVOoTCnClUIytrvd+aZvCn98RYEfz1eEMgf9uplHDK1gTUvgafMIUGQ9/k893UC9Ff0qr9XjQaAIovU1dRUbjJw5y3x0qEZJvASp9ag2xGu1TEjBUjPzcmKJJfdcEhbHIHgvmJuyo6jbQuHA6xN4jeQXc4dVngGiVk7Sa6EIntVt5ilXxBd4WhsHKQRYcs3qjoqUNAuOxw1F0OnqhvtopwGIe8wEOWkAQ5hxNogoJm7cNu86mIsQ4FPCp2/3nUh1G3csF09OYBWtZZUjdGfh+ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13015025)(13018025)(13024025)(13023025)(5005006)(13017025)(8121501046)(3002001)(10201501046); SRVR:CY1PR0501MB1161; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0501MB1161; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0501MB1161; 4:QlMo7+HPQck9WOEoECg2I2zq3hwJhGg284JqeRVQNLbcuuNS5vgguyW448ECjXVh5LEp1VMayWzN0WqbWjJbgD82OkcS/lPdYPJI268UI24dkybW2D8kWjWrbW79As71ud40Hr9Mu7JzkYyyFyMEZ4QlD85TDjm9/utX546xQUwnvHnsoIHJsjLW+iTL/X/unVG88+um76cIXfxEWPYO+XDuWQVw8MElJlTMjLqpB/uKaJge4DnjxMlLGJsCDyj8Oy42m1oGG12vbxeprdWDdMSCx80WjHdCuZKkGJ5RSYfG/QGZ+q2DL9aYnXxGEpsy4+XzWAaKMpVan6GN2hhKYO6mWySBQPcX/nj1BDkJBk3kmmd41XN3JvH3WEnAKGtYj6fieK00IPSEAcncevzH+vk5lgjFvji6N/uWCdHXR997kTR7OW8rjpbeu15/5ngR9xDECq7mLWV84Qc6P99xLw== X-Forefront-PRVS: 0884AAA693 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0501MB1161; 23:R6yFYKxtOBRFZzvoMwTrENaKNhYnr1ZSTtm6lxm?= =?us-ascii?Q?uaQgLlRlHP1zHgGZq2ITPhikzxIhQd2PaDnyU3RGGlnt//b502Wp1CBtiBMi?= =?us-ascii?Q?vNKy8SomgxNvVWJu6u2ZLk8/ubjwrZ+QZQJVoeBQdSX7UTlrONyxfp20CxsC?= =?us-ascii?Q?XdX4D082sZhJnlH64xYVJZ7jScj0MbmXFcNYqmA3hNhB+tY8cP1AQSwzR/fk?= =?us-ascii?Q?2A4zRW9OwkyhiCWXp3NsesPqVMGxFGbwu5tWbB2RI6f/ucC3xSRh/ZOASYgT?= =?us-ascii?Q?dUXvR3sWFAG72iLtNncd3ycvgwFDTjGzzzMJrRmJdykxMFQZASdVgRG/jIn7?= =?us-ascii?Q?I5VTZOo68QUxYwjS0AWk473vw1fSprOQ+oB3CtkAV/+7UcYOlT1fLLjeVz5L?= =?us-ascii?Q?3J7ffewGNkE+spsKD6JUdrD0hqyPlcuFnOLsZ6hGuHUixy3Xi2WfGnyW4ifC?= =?us-ascii?Q?nTYLi8b10abWxAlOr9kqw0LsX9X7ewUtgcveiLtEQFf7Kn2KdmtdWSacYG69?= =?us-ascii?Q?1sAuQGIW7tcsuZy+vRz8X1LIUcF5MKarCnsAJboH8sA/PZrM5aIU4JJIJF05?= =?us-ascii?Q?fcY4vhKVqyigocm5K7N+Seyyn7hiXWX+2z2KYCKUJrwWf9MmNDor6UrSzKVA?= =?us-ascii?Q?UEJS1uwF8P9+u1pUXmJ9Qnab6L3PSkoZXhgDmjiXOQTXJLSwvl7hvAxGVYqR?= =?us-ascii?Q?iVw5cthwDTTc7qOeihLP7UVKho3nqJT9b4u+N35JcReU0I2bf0Csiq33qT9r?= =?us-ascii?Q?lYI0RXcl1ZhY0ZnObhL3+sCG2jdHJclt+1RRB8ea+tpztIVlpdtkqSaO5/7H?= =?us-ascii?Q?dKMi4YKyq9qjnzFR3JtpYhWTbcsu4sbhy9TduJ1VkArwPTCXYc1VvWZrgUHP?= =?us-ascii?Q?uWxQZK9hODLAjjFnxre5dRHLEebyonip+rXGyDnik6xCHieDKNa4BaX/FoGw?= =?us-ascii?Q?YkCuH0U8c/4Ax5VmzO26K/TvPXrNPoX3Bs7p48xhgHT/Y2ofY1hUEWBl0lyf?= =?us-ascii?Q?MH4T22TR+TpyQXRdJ+pYk0GP0pW1MGJWpy8GTeO1Z01lM5N0GZWySVz4tann?= =?us-ascii?Q?xJV/SH9YLylzDlySPplhIEHIIg03eeMfWiyc5LQ94b18sSCCfEA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0501MB1161; 5:qJzzQZhm/0G0DR192jk1bQrbZqyQ18dOhMhDYAwtTLZhXhlID1PwMG34gEqwJdv14O06Wa7hi2RFlndhf+itan1D1XIVMdS79B914peYOjJaRaMQLG7iv3CozYpT/SYJiB1VOMuGHoohfuKS8N7h6g==; 24:BxvCds1ZR5j+6B2zIw3H+R/XuUJv04Wdc1ZKiqepS7CJ7/PrObY5j++t+fS6pFtzBZ46lQ/tPuKuFCedCfxcMngcoAxmaI/qOYgtSzGnnXc= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2016 04:30:41.8033 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.19]; Helo=[p-emfe01b-sac.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0501MB1161 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Mar 2016 04:46:19 -0000 Bryan Drewery wrote: > Btw I recently hooked up MK_TESTS to DIRDEPS_BUILD and added them all > (at the time) to targets/. Hmm how did you do that? In our build local.dirdeps.mk checks each DEP_RELDIR to see if there is a tests/Makefile.depend.host below it, and if so adds it to the dependency graph - but not to the dependencies of DEP_RELDIR - which could introduced circular dependencies. [It also has to check if ${DEP_RELDIR}/tests is listed as broken for the current host os - not all tests can run on all build hosts] Thus we build all the tests (and only the tests) relevant to what we are building. And since when building tests for "host" we run them immediately, if any fail the build fails. Hooking all the tests into a tests target is useful too of course.