From owner-svn-src-all@FreeBSD.ORG Wed Jul 3 10:33:37 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id B8D383DA; Wed, 3 Jul 2013 10:33:37 +0000 (UTC) (envelope-from davide.italiano@gmail.com) Received: from mail-ve0-x22f.google.com (mail-ve0-x22f.google.com [IPv6:2607:f8b0:400c:c01::22f]) by mx1.freebsd.org (Postfix) with ESMTP id 2B06D1BC7; Wed, 3 Jul 2013 10:33:37 +0000 (UTC) Received: by mail-ve0-f175.google.com with SMTP id da11so5798366veb.34 for ; Wed, 03 Jul 2013 03:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=5ymsap6FFTpKn5RQGS9oo6fqKIjtwJEFDYAfbC93Yok=; b=pqJpvHBM4BuJnbgyFsPUWFE82OyGjtmeyX5RKWeVkkZvKp8hfws9n0NlWeWUVCRGb2 IF6k27Ta3Xo3UJPqHmD6gj7FVVgjPdg3i99msLo2hFlau6eVee3KEVsjYmwGUlQvJZNA AJM2snSB5EgHTPniQ47HYGa9DOwMH9vqx/HnnrQPKHqY/Tt9CNhAkq0YSSahLmwFtt5Y LxLU5BLe4sbxQLKdcnj3qfc4gSpVBtK2D+r0DjEuTBgaq0jytVmXrmfI7VA7a7vxbvVZ 1aE+84Q4/kKAYG7R1HuW3hxv3c9JE3AkPrDOhXA55sECeDdlflz/uNKxlZDbhq9MNvL1 K2XA== MIME-Version: 1.0 X-Received: by 10.52.158.164 with SMTP id wv4mr32188vdb.106.1372847616194; Wed, 03 Jul 2013 03:33:36 -0700 (PDT) Sender: davide.italiano@gmail.com Received: by 10.220.206.202 with HTTP; Wed, 3 Jul 2013 03:33:36 -0700 (PDT) In-Reply-To: <20130703092807.GB2294@acme.spoerlein.net> References: <201306282100.r5SL08kx093999@svn.freebsd.org> <20130703092807.GB2294@acme.spoerlein.net> Date: Wed, 3 Jul 2013 12:33:36 +0200 X-Google-Sender-Auth: gIzdUc5dqRKPN_UPB6-xpfZLnjM Message-ID: Subject: Re: svn commit: r252356 - in head: contrib/smbfs/mount_smbfs etc/defaults etc/mtree include lib lib/libprocstat rescue/rescue sbin/mount share/examples share/examples/etc share/mk sys/conf sys/kern sys... From: Davide Italiano To: =?ISO-8859-1?Q?Ulrich_Sp=F6rlein?= , Davide Italiano , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jul 2013 10:33:37 -0000 On Wed, Jul 3, 2013 at 11:28 AM, Ulrich Sp=F6rlein wrote: > On Fri, 2013-06-28 at 21:00:08 +0000, Davide Italiano wrote: >> Author: davide >> Date: Fri Jun 28 21:00:08 2013 >> New Revision: 252356 >> URL: http://svnweb.freebsd.org/changeset/base/252356 >> >> Log: >> - Trim an unused and bogus Makefile for mount_smbfs. >> - Reconnect with some minor modifications, in particular now selsocket= () >> internals are adapted to use sbintime units after recent'ish calloutng >> switch. > > yay, for reconnecting this to the build. Now Coverity Scan is "seeing" > this code and there are dozens of double frees in the form: > > smb_rq_done(rqp); > free(rqp, M_SMBFSDATA); > > But smb_rq_done() is already calling free(rqp). This seems easy to audit > and fix. > (sometimes the order is swapped, so it's a USE_AFTER_FREE instead) > > This is CIDs 1042109 -- 1042126, all in smbfs_smb.c. > > Thanks for looking into this > Uli I've just committed a fix. If there's something I missed don't hesitate to poke me privately. Thanks, --=20 Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare