From owner-svn-src-user@FreeBSD.ORG  Sat Apr 11 14:15:10 2009
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4D22B106566C;
	Sat, 11 Apr 2009 14:15:10 +0000 (UTC)
	(envelope-from piso@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 3BD998FC08;
	Sat, 11 Apr 2009 14:15:10 +0000 (UTC)
	(envelope-from piso@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n3BEFA4Y088477;
	Sat, 11 Apr 2009 14:15:10 GMT (envelope-from piso@svn.freebsd.org)
Received: (from piso@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id n3BEFAZk088475;
	Sat, 11 Apr 2009 14:15:10 GMT (envelope-from piso@svn.freebsd.org)
Message-Id: <200904111415.n3BEFAZk088475@svn.freebsd.org>
From: Paolo Pisati <piso@FreeBSD.org>
Date: Sat, 11 Apr 2009 14:15:10 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-user@freebsd.org
X-SVN-Group: user
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r190923 - user/piso/ipfw/sys/netinet/libalias
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the experimental &quot; user&quot;
	src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
	<mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 Apr 2009 14:15:10 -0000

Author: piso
Date: Sat Apr 11 14:15:09 2009
New Revision: 190923
URL: http://svn.freebsd.org/changeset/base/190923

Log:
  In case of malformed packets (or some other unrecoverable error), toss the packet: fix a but introduced in rev 1.20.

Modified:
  user/piso/ipfw/sys/netinet/libalias/alias_nbt.c

Modified: user/piso/ipfw/sys/netinet/libalias/alias_nbt.c
==============================================================================
--- user/piso/ipfw/sys/netinet/libalias/alias_nbt.c	Sat Apr 11 14:13:39 2009	(r190922)
+++ user/piso/ipfw/sys/netinet/libalias/alias_nbt.c	Sat Apr 11 14:15:09 2009	(r190923)
@@ -93,8 +93,7 @@ static int 
 protohandler1(struct libalias *la, struct ip *pip, struct alias_data *ah)
 {
 	
-	AliasHandleUdpNbt(la, pip, ah->lnk, ah->aaddr, *ah->aport);
-	return (0);
+	return (AliasHandleUdpNbt(la, pip, ah->lnk, ah->aaddr, *ah->aport));
 }
 
 static int 
@@ -123,9 +122,8 @@ static int 
 protohandler2out(struct libalias *la, struct ip *pip, struct alias_data *ah)
 {
 	
-	AliasHandleUdpNbtNS(la, pip, ah->lnk, &pip->ip_src, ah->sport,
- 			    ah->aaddr, ah->aport);
-	return (0);
+	return (AliasHandleUdpNbtNS(la, pip, ah->lnk, &pip->ip_src, ah->sport,
+ 	    ah->aaddr, ah->aport));
 }
 
 /* Kernel module definition. */