From owner-freebsd-multimedia@FreeBSD.ORG  Wed May 14 08:06:12 2014
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A009D906
 for <freebsd-multimedia@FreeBSD.org>; Wed, 14 May 2014 08:06:12 +0000 (UTC)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 6555D25FB
 for <freebsd-multimedia@FreeBSD.org>; Wed, 14 May 2014 08:06:11 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id D69A71FE029
 for <freebsd-multimedia@FreeBSD.org>; Wed, 14 May 2014 10:06:10 +0200 (CEST)
Message-ID: <53732425.7070600@selasky.org>
Date: Wed, 14 May 2014 10:07:01 +0200
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: freebsd-multimedia@FreeBSD.org
Subject: Re: OSS mains HUM filtering 50Hz / 60Hz ?
References: <537264F6.5060808@selasky.org>
In-Reply-To: <537264F6.5060808@selasky.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia/>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
 <mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 May 2014 08:06:12 -0000

On 05/13/14 20:31, Hans Petter Selasky wrote:
> Hi,
>
> Some of my USB audio headsets seems to be picking up mains HUM even if
> powered from battery. At first I thought the mains HUM came from the
> computer, but then I did some work and I verified my findings by
> sampling the AC network using a non-switching power supply. Maybe it
> does not belong in the FreeBSD audio stack, but I think it would be very
> clever to have a configurable band-reject filter in the FreeBSD DSP
> framework for 50 and 60Hz? Do we have such a filter mechanism already?
>
> Not sure if this is a so-called "feature" or not ... :-)
>
> http://en.wikipedia.org/wiki/Mains_hum
>
> http://www.selasky.org/hans_petter/hum.png
>
> --HPS

Hi,

I tried the following patch with some success:

=== pcm/feeder_chain.c
==================================================================
--- pcm/feeder_chain.c	(revision 265912)
+++ pcm/feeder_chain.c	(local)
@@ -721,7 +721,7 @@

  		/* Soft EQ only applicable for PLAY. */
  		if (cdesc.dummy == 0 &&
-		    c->direction == PCMDIR_PLAY && (d->flags & SD_F_EQ) &&
+		    (d->flags & SD_F_EQ) &&
  		    (((d->flags & SD_F_EQ_PC) &&
  		    !(c->flags & CHN_F_HAS_VCHAN)) ||
  		    (!(d->flags & SD_F_EQ_PC) && !(c->flags & CHN_F_VIRTUAL))))


And setting:

hint.pcm.0.eq=1
hint.pcm.1.eq=1
hint.pcm.2.eq=1
hint.pcm.3.eq=1

--HPS