From owner-freebsd-threads@FreeBSD.ORG  Tue Apr 24 17:34:56 2012
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E54AB1065672
	for <freebsd-threads@freebsd.org>; Tue, 24 Apr 2012 17:34:56 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id B9FE88FC0A
	for <freebsd-threads@freebsd.org>; Tue, 24 Apr 2012 17:34:56 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 06546B95B;
	Tue, 24 Apr 2012 13:34:56 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Date: Tue, 24 Apr 2012 13:34:37 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; )
References: <20120423084120.GD76983@zxy.spb.ru>
	<201204241110.14017.jhb@freebsd.org>
	<20120424165842.GZ2358@deviant.kiev.zoral.com.ua>
In-Reply-To: <20120424165842.GZ2358@deviant.kiev.zoral.com.ua>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201204241334.37580.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Tue, 24 Apr 2012 13:34:56 -0400 (EDT)
Cc: jack.ren@intel.com, freebsd-threads@freebsd.org
Subject: Re: About the memory barrier in BSD libc
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2012 17:34:57 -0000

On Tuesday, April 24, 2012 12:58:42 pm Konstantin Belousov wrote:
> On Tue, Apr 24, 2012 at 11:10:13AM -0400, John Baldwin wrote:
> > Could you move the extern and THREAD_LOCK/UNLOCK macros into the stdio
> > private header file?
> 
> This requires more glue because spinlock.h is separate from libc_private.h.
> I also added a comment trying to explain why assignment is braced with lock.

This looks great, thanks!

-- 
John Baldwin