From owner-svn-src-all@FreeBSD.ORG Tue May 18 18:10:56 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7DDFD1065675; Tue, 18 May 2010 18:10:56 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 22CEC8FC1C; Tue, 18 May 2010 18:10:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o4II7MaB025503; Tue, 18 May 2010 12:07:22 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Tue, 18 May 2010 12:07:48 -0600 (MDT) Message-Id: <20100518.120748.450985660133983957.imp@bsdimp.com> To: uqs@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <201005141426.o4EEQu7B081269@svn.freebsd.org> References: <201005141426.o4EEQu7B081269@svn.freebsd.org> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r208075 - in head/usr.sbin/apmd: . contrib X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2010 18:10:56 -0000 : Modified: head/usr.sbin/apmd/apmd.c : - execl(_PATH_BSHELL, "sh", "-c", p->line, (char *)NULL); : + execl(_PATH_BSHELL, "sh", "-c", p->line, NULL); This looks like a regression to me. Since execl is varadic, you do need this cast... Warner