From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Apr 23 18:00:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 008231065673 for ; Thu, 23 Apr 2009 18:00:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C7D988FC21 for ; Thu, 23 Apr 2009 18:00:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n3NI01qn056042 for ; Thu, 23 Apr 2009 18:00:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n3NI01eN056041; Thu, 23 Apr 2009 18:00:01 GMT (envelope-from gnats) Resent-Date: Thu, 23 Apr 2009 18:00:01 GMT Resent-Message-Id: <200904231800.n3NI01eN056041@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Tony Finch Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6E6FE106564A for ; Thu, 23 Apr 2009 17:56:51 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 5D8108FC1A for ; Thu, 23 Apr 2009 17:56:51 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n3NHupNu001635 for ; Thu, 23 Apr 2009 17:56:51 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n3NHupUr001623; Thu, 23 Apr 2009 17:56:51 GMT (envelope-from nobody) Message-Id: <200904231756.n3NHupUr001623@www.freebsd.org> Date: Thu, 23 Apr 2009 17:56:51 GMT From: Tony Finch To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/133954: git help uses wrong MANPATH X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Apr 2009 18:00:02 -0000 >Number: 133954 >Category: ports >Synopsis: git help uses wrong MANPATH >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Apr 23 18:00:01 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Tony Finch >Release: 7.1-RELEASE >Organization: >Environment: FreeBSD black.csi.cam.ac.uk 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan 1 14:37:25 UTC 2009 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: "git help" sets the MANPATH environment variable to ensure that it includes the path to git's man pages before invoking man. Its build system's man path is ${PREFIX}/share/man but the FreeBSD port installs them in /usr/local/man. Therefore git adds an incorrect entry to the MANPATH. If the user did not have a MANPATH set then the new path set by git overrides /etc/manpath.config, so man can no longer find the desired page. In this situation git includes a trailing : in order to make man on Linux look in the default places, but man on FreeBSD does not do this. >How-To-Repeat: $ unset MANPATH; git help tag No manual entry for git-tag >Fix: Patch git's build system so its idea of the man path agrees with where the man pages are installed by the port. Patch attached with submission follows: diff --git a/port/Makefile b/port/Makefile index a4d3f5a..ae3270b 100644 --- a/port/Makefile +++ b/port/Makefile @@ -253,7 +253,8 @@ verify: checksum ${DISTDIR}/${PORTNAME}-${PORTVERSION}${EXTRACT_SUFX} post-patch: - @${REINPLACE_CMD} -e 's|share/man/man3|man/man3|' ${WRKSRC}/perl/Makefile.PL + @${REINPLACE_CMD} -e 's|share/man|man|' ${WRKSRC}/perl/Makefile.PL \ + ${WRKSRC}/Makefile ${WRKSRC}/Documentation/Makefile .ifndef (WITH_CVS) @${REINPLACE_CMD} -e '/git-cvsexportcommit.perl/d; \ /git-cvsimport.perl/d; \ >Release-Note: >Audit-Trail: >Unformatted: