From owner-cvs-src@FreeBSD.ORG  Sat Apr  9 11:53:17 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 28D6A16A4CE; Sat,  9 Apr 2005 11:53:17 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 0D05943D1F; Sat,  9 Apr 2005 11:53:17 +0000 (GMT)
	(envelope-from jeff@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j39BrGFF033375;
	Sat, 9 Apr 2005 11:53:16 GMT
	(envelope-from jeff@repoman.freebsd.org)
Received: (from jeff@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j39BrGm2033374;
	Sat, 9 Apr 2005 11:53:16 GMT
	(envelope-from jeff)
Message-Id: <200504091153.j39BrGm2033374@repoman.freebsd.org>
From: Jeff Roberson <jeff@FreeBSD.org>
Date: Sat, 9 Apr 2005 11:53:16 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/kern vfs_lookup.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Apr 2005 11:53:17 -0000

jeff        2005-04-09 11:53:16 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             vfs_lookup.c 
  Log:
   - If we vrele() a dvp while the child is locked we can potentially deadlock
     when vrele() acquires the directory lock in the wrong order.  Fix this
     via the following changes:
   - Keep the directory locked after VOP_LOOKUP() until we've determined
     what we're going to do with the child.  This allows us to remove the
     complicated post LOOKUP code which determins whether we should lock or
     unlock the parent.  This means we may have to vput() in the appropriate
     cases later, rather than doing an unsafe vrele.
   - in NDFREE() keep two flags to indicate whether we need to unlock vp or
     dvp.  This allows us to vput rather than vrele in the appropriate
     cases without rechecking the flags.  Move the code to handle dvp after
     we handle vp.
   - Remove some dead code from namei() that was the result of changes to
     VFS_LOCK_GIANT().
  
  Sponsored by:   Isilon Systems, Inc.
  
  Revision  Changes    Path
  1.78      +60 -51    src/sys/kern/vfs_lookup.c