Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Aug 2016 10:51:53 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org
Subject:   svn commit: r304397 - stable/10/sys/dev/ntb
Message-ID:  <201608181051.u7IAprxw029782@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Thu Aug 18 10:51:53 2016
New Revision: 304397
URL: https://svnweb.freebsd.org/changeset/base/304397

Log:
  MFC r302529: Remove callout_reset(link_work) from ntb_transport_attach().
  
  At that point link is quite likely not established yet, so messing with
  scratch registers is premature there.  Original commit message mentioned
  code diff reduction from Linux, but this line is not present in Linux now.

Modified:
  stable/10/sys/dev/ntb/ntb_transport.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/ntb/ntb_transport.c
==============================================================================
--- stable/10/sys/dev/ntb/ntb_transport.c	Thu Aug 18 10:51:18 2016	(r304396)
+++ stable/10/sys/dev/ntb/ntb_transport.c	Thu Aug 18 10:51:53 2016	(r304397)
@@ -398,7 +398,6 @@ ntb_transport_attach(device_t dev)
 	nt->link_is_up = false;
 	NTB_LINK_ENABLE(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO);
 
-	callout_reset(&nt->link_work, 0, ntb_transport_link_work, nt);
 	if (enable_xeon_watchdog != 0)
 		callout_reset(&nt->link_watchdog, 0, xeon_link_watchdog_hb, nt);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201608181051.u7IAprxw029782>