From owner-cvs-src@FreeBSD.ORG Sat Aug 20 17:06:35 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FC2516A41F; Sat, 20 Aug 2005 17:06:35 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 398C943D5F; Sat, 20 Aug 2005 17:06:32 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id A6B8052C99; Sat, 20 Aug 2005 19:06:30 +0200 (CEST) Received: from localhost (dkd118.neoplus.adsl.tpnet.pl [83.24.7.118]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 13A2F52C6F; Sat, 20 Aug 2005 19:06:24 +0200 (CEST) Date: Sat, 20 Aug 2005 19:06:08 +0200 From: Pawel Jakub Dawidek To: Gordon Tetlow Message-ID: <20050820170608.GB749@garage.freebsd.pl> References: <200508120005.j7C05ARc090857@repoman.freebsd.org> <20050815053757.GB2660@green.homeunix.org> <20050815070033.GA8368@garage.freebsd.pl> <20050815125814.GC2660@green.homeunix.org> <20050816081644.GA3944@garage.freebsd.pl> <1124182906.2492.4.camel@buffy.york.ac.uk> <20050816095217.GB3944@garage.freebsd.pl> <43028269.50904@FreeBSD.org> <20050817084749.GC11066@garage.freebsd.pl> <43056CAC.6040105@tetlows.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+pHx0qQiF2pBVqBT" Content-Disposition: inline In-Reply-To: <43056CAC.6040105@tetlows.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng devel (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: Doug Barton , Gavin Atkinson , cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, freebsd-arch@freebsd.org Subject: Re: cvs commit: src/sys/geom/label g_label.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Aug 2005 17:06:36 -0000 --+pHx0qQiF2pBVqBT Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 18, 2005 at 10:22:52PM -0700, Gordon Tetlow wrote: +> >On Tue, Aug 16, 2005 at 05:18:49PM -0700, Doug Barton wrote: +> >+> Pawel Jakub Dawidek wrote: +> >+> +> >Because '/' creates a directory and I want each label to be repr= esented +> >+> >only by one file. +> >+> +> I think what people are saying is that they like the directory cr= eating behavior. Can you explain your rationale in more detail? +> >Actually, I don't really care. All I wanted was one label to be represe= nted +> >by one single file. That's all. For me, leaving it as it is just asks f= or +> >troubles. +> >I can live without this change, really. This is something I'd like to a= sk +> >about our TRB, but unfortunately it was retired yesterday:) +> >CCing to freebsd-arch@. +> >The question(s) is(are): Should we allow '/' in labels or should we rep= lace +> >it with something (eg. '_')? Maybe we should only deny labels with '/..= /'? +> >=20 +> When I wrote GEOM_VOL_FFS, I wrote it with the idea that you could make = a heirarchy of providers in /dev/vol. Coming from an environment where it w= asn't unusual for a=20 +> single machine to have 30 to 40 disk available to it, it seemed natural = that we should allow administrators the ability to define how they wanted t= hings mapped out. +>=20 +> Now that I have just gone back and looked at the code that I wrote, I di= dn't allow non-alphanumerics in the volume name (although I actually didn't= check it when creating=20 +> the provider). I seem to recall making that decision specifically to get= around the ../ tree traversal. +>=20 +> Anyway, I think it comes down to tools, not policy. I think "/" should b= e allowed. Ok, guys, I backed-out the change. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --+pHx0qQiF2pBVqBT Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (FreeBSD) iD8DBQFDB2MAForvXbEpPzQRAn3rAJ9jsi94iwYeWOdPjqezeM834jOPMwCcD6PY I91cBgIFDxwIi3opZnAxtpI= =OYbX -----END PGP SIGNATURE----- --+pHx0qQiF2pBVqBT--