From owner-svn-src-all@freebsd.org Tue Mar 21 06:50:33 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DD2A7D16A45; Tue, 21 Mar 2017 06:50:33 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A589F310; Tue, 21 Mar 2017 06:50:33 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-io0-x22a.google.com with SMTP id z13so43504089iof.2; Mon, 20 Mar 2017 23:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=EegxHUh6t6cGQDK5Kre0xHxO3/3UGvtOhHr/nG0yiMc=; b=Zgb9+0pn19Zh/Oo8zjIeY2DEuRrVdU+JxdP8AhwznqF+JwqTuXFuCxmNf9bBD2FGrW JyGawQXiZZNgfurclvB+iMCsYrRy9oWc7hW1oJnrewED0sablWpFBF1x2ewrI+mFDJyt pn61auxCCqZN1JUpIdOTU5+S3c8dcoGI0JEdmS2ONRsB/bUCrY68hAfHIaq62Zr3CH63 cUZXeFYfrzwmh3ptyTuqXA5LDmBZiXWCfJs7IRTsEi6tugYsntfHpOyuILSKbJPbazQ2 SaBdzET6HGPFs1/s3GG2h5rA/dcZanydYApHdP6Avk2X3TLYgaffZRJmEdwu6x7Y1aOI 81NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=EegxHUh6t6cGQDK5Kre0xHxO3/3UGvtOhHr/nG0yiMc=; b=YFNwj3jVxmGGdbX9o3xiSQIoqIxbyuj/9xDvgSC2VZ6lN1BgW+goZSc7uAyCE5ioTB YmzDTZbJwYN5ArAvKpx+CyXtBrmi+3He+Q7SSSYLwv3PG3wSWkbOKFd8fEs2a2KBH+nh hDmqgm8H9x2FhzTY1m8XRy8tS2YS3d0m0jCOH2mHfuiBufBIjoj7QjW9KErY0yUcrnRb /mHKDNrYvQF1VXcZtOUA8u3sWELJ6QNJZACQX6OdCl/mui56b/cGZ1HV5V+lD4zSP7OB n1tW/8UAYtfTCP3kgUTIWg0pgYoiYjVoNcCmIViIoMUecOQ5qD/7/PcapGP10Tv8xony 6BAA== X-Gm-Message-State: AFeK/H1k+UZtjl81MCRL9gDjNXFH7b9FEZaboZze3oPcu0ZsIjDYxTI+F/z6PQXGTfxzrkgSX6jSDHzOTzcQEg== X-Received: by 10.107.182.9 with SMTP id g9mr27115743iof.233.1490079032793; Mon, 20 Mar 2017 23:50:32 -0700 (PDT) MIME-Version: 1.0 Sender: antoine.brodin.freebsd@gmail.com Received: by 10.107.13.15 with HTTP; Mon, 20 Mar 2017 23:50:32 -0700 (PDT) In-Reply-To: <20170321064154.GL23308@FreeBSD.org> References: <201703210639.v2L6dnRf055522@repo.freebsd.org> <20170321064154.GL23308@FreeBSD.org> From: Antoine Brodin Date: Tue, 21 Mar 2017 07:50:32 +0100 X-Google-Sender-Auth: XdoNhYmBrtILV6zrS-t8Y3VV20s Message-ID: Subject: Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt To: Gleb Smirnoff Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org, FreeBSD Ports Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 06:50:34 -0000 On Tue, Mar 21, 2017 at 7:41 AM, Gleb Smirnoff wrote: > Hi! > > This change is known to break a ton of ports. More than 100 if > counting depends. I'm sorry for that and I already started to fix > them. > > Please send all new breakages to me. Hi, Exp-runs should happen before breakage happens, not after. If you already know that it breaks hundreds of ports, please revert and request an exp-run. Antoine (with hat: portmgr) > On Tue, Mar 21, 2017 at 06:39:49AM +0000, Gleb Smirnoff wrote: > T> Author: glebius > T> Date: Tue Mar 21 06:39:49 2017 > T> New Revision: 315662 > T> URL: https://svnweb.freebsd.org/changeset/base/315662 > T> > T> Log: > T> Hide struct inpcb, struct tcpcb from the userland. > T> > T> This is a painful change, but it is needed. On the one hand, we avoid > T> modifying them, and this slows down some ideas, on the other hand we still > T> eventually modify them and tools like netstat(1) never work on next version of > T> FreeBSD. We maintain a ton of spares in them, and we already got some ifdef > T> hell at the end of tcpcb. > T> > T> Details: > T> - Hide struct inpcb, struct tcpcb under _KERNEL || _WANT_FOO. > T> - Make struct xinpcb, struct xtcpcb pure API structures, not including > T> kernel structures inpcb and tcpcb inside. Export into these structures > T> the fields from inpcb and tcpcb that are known to be used, and put there > T> a ton of spare space. > T> - Make kernel and userland utilities compilable after these changes. > T> - Bump __FreeBSD_version. > T> > T> Reviewed by: rrs, gnn > T> Differential Revision: D10018