From owner-cvs-all  Sun May 10 20:19:32 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id UAA26263
          for cvs-all-outgoing; Sun, 10 May 1998 20:19:32 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from time.cdrom.com (root@time.cdrom.com [204.216.27.226])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id UAA26257
          for <committers@FreeBSD.ORG>; Sun, 10 May 1998 20:19:30 -0700 (PDT)
          (envelope-from jkh@time.cdrom.com)
Received: from time.cdrom.com (jkh@localhost.cdrom.com [127.0.0.1])
	by time.cdrom.com (8.8.8/8.8.8) with ESMTP id UAA08848;
	Sun, 10 May 1998 20:18:39 -0700 (PDT)
	(envelope-from jkh@time.cdrom.com)
To: dag-erli@ifi.uio.no (Dag-Erling Coidan =?iso-8859-1?Q?Sm=F8rgrav?= )
cc: committers@FreeBSD.ORG
Subject: Re: libfetch 
In-reply-to: Your message of "10 May 1998 21:37:03 +0200."
             <xzpiundc3z4.fsf@hrotti.ifi.uio.no> 
Date: Sun, 10 May 1998 20:18:39 -0700
Message-ID: <8844.894856719@time.cdrom.com>
From: "Jordan K. Hubbard" <jkh@time.cdrom.com>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

> Anyway, a very rough draft of libfetch (with support for "file" and
> "http"² URLs, but not much else) can be found on the following page:

Thanks for the pointer.  Some quick comments:

1. I don't suppose you could switch to something along the lines of K&R
   or KNF (style(9)) formatting for this code before it gets too much
   larger?  I think that a library like this is going to see a lot of
   ongoing maintenance by others than yourself, and I certainly find
   many of these one-line statements of yours (e.g.
   if (URL[1] != '/') { p = URL; goto nohost; } else URL += 2;) to be
   rather difficult to read.

   I'm not trying to get you to change your personal formatting style since
   that's a religious issue, I'm simply asking that any code donated to
   the wider world of FreeBSD be closer to KNF, or K&R if you're like me and
   go for even OLDER (and, IMHO, precedent) standards in code formatting,
   so that us old farts can just jump in and read it without squinting. :)

2. I thought that fetchFooURL() would take an extra arg for setting
   connection behavior?  How do I do a fetchFooURL() with FTP passive
   mode set or tell the file:/ stuff to symlink instead of copying, for
   example?

3. Unless this is a complete from-scratch work (in which case, more
   power to ya!) you might think of crediting folks like Bill Fenner
   in the copyrights for anything you've derived from their work, just
   to be a nice guy. :)

Thanks, it looks like a good start in any case!

- Jordan

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message