Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 24 Aug 2011 09:56:14 GMT
From:      Ruslan Mahmatkhanov <cvs-src@yandex.ru>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/160051: [PATCH] net/py-s3cmd: eliminate py-elementtree dependency
Message-ID:  <201108240956.p7O9uEIK082484@red.freebsd.org>
Resent-Message-ID: <201108241000.p7OA0M43013238@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         160051
>Category:       ports
>Synopsis:       [PATCH] net/py-s3cmd: eliminate py-elementtree dependency
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 24 10:00:22 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Ruslan Mahmatkhanov
>Release:        9.0-BETA1
>Organization:
>Environment:
9.0-BETA1 i386
>Description:
- bump USE_PYTHON to 2.5+ since python24 is no more supported upstream (actually python25 too, but the point is to not depend on 24)
- remove dependency on elementtree, since elementtree is a part of python since 2.5, so this dependency isn't needed (please see http://docs.python.org/library/xml.etree.elementtree.html)
- while here add license
- use dirrm instead of dirrmtry while dealing with package directory in PYTHON_SITELIBDIR in pkg-plist - i've checked it both with and without NOPORTDOCS=yes and all is work as expected.
- bump PORTREVISION cause of dependencies list change

tinderbuild log (8.2):
http://happy-nation.by.ru/ports/tb/8.2/py27-s3cmd-1.0.1_1.log

>How-To-Repeat:

>Fix:


Patch attached with submission follows:

diff -uN py-s3cmd.orig/Makefile py-s3cmd/Makefile
--- py-s3cmd.orig/Makefile	2011-06-20 12:05:14.000000000 +0400
+++ py-s3cmd/Makefile	2011-08-24 13:36:40.000000000 +0400
@@ -7,6 +7,7 @@
 
 PORTNAME=	s3cmd
 PORTVERSION=	1.0.1
+PORTREVISION=	1
 CATEGORIES=	net python
 MASTER_SITES=	SF/s3tools/${PORTNAME}/${PORTVERSION}
 PKGNAMEPREFIX=	${PYTHON_PKGNAMEPREFIX}
@@ -14,11 +15,10 @@
 MAINTAINER=	clsung@FreeBSD.org
 COMMENT=	Unix-like tools to manipulate stored files from the command line
 
-RUN_DEPENDS=	${PYTHON_SITELIBDIR}/elementtree/__init__.py:${PORTSDIR}/devel/py-elementtree
-BUILD_DEPENDS=	${RUN_DEPENDS}
+LICENSE=	GPLv2
 
 USE_PYDISTUTILS=	yes
-USE_PYTHON=	yes
+USE_PYTHON=	2.5+
 
 MAN1=		s3cmd.1
 
diff -uN py-s3cmd.orig/pkg-plist py-s3cmd/pkg-plist
--- py-s3cmd.orig/pkg-plist	2010-12-31 04:54:16.000000000 +0300
+++ py-s3cmd/pkg-plist	2011-08-24 13:38:15.000000000 +0400
@@ -45,5 +45,5 @@
 %%PYTHON_SITELIBDIR%%/S3/__init__.pyc
 %%PYTHON_SITELIBDIR%%/S3/__init__.pyo
 bin/s3cmd
-@dirrmtry %%PYTHON_SITELIBDIR%%/S3
+@dirrm %%PYTHON_SITELIBDIR%%/S3
 %%PORTDOCS%%@dirrm %%DOCSDIR%%


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201108240956.p7O9uEIK082484>