From owner-freebsd-net@FreeBSD.ORG Mon Oct 22 16:20:38 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 54D794D1; Mon, 22 Oct 2012 16:20:38 +0000 (UTC) (envelope-from eric@vangyzen.net) Received: from aussmtpmrkps320.us.dell.com (aussmtpmrkps320.us.dell.com [143.166.224.254]) by mx1.freebsd.org (Postfix) with ESMTP id 1337B8FC08; Mon, 22 Oct 2012 16:20:36 +0000 (UTC) X-Loopcount0: from 64.238.244.148 X-IronPort-AV: E=Sophos;i="4.80,630,1344229200"; d="scan'208";a="6571789" Message-ID: <50857210.3090200@vangyzen.net> Date: Mon, 22 Oct 2012 11:19:28 -0500 From: Eric van Gyzen User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:14.0) Gecko/20120822 Thunderbird/14.0 MIME-Version: 1.0 To: freebsd-net@freebsd.org, "Bjoern A. Zeeb" Subject: [patch] Review: Fix Tahi "Redirected On-link" Test Case Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2012 16:20:38 -0000 Bjoern and net@: I would appreciate your review and comments on the following patches. http://vangyzen.net/FreeBSD/patches/redir_onlink_8_rev1.diff http://vangyzen.net/FreeBSD/patches/redir_onlink_9_rev1.diff http://vangyzen.net/FreeBSD/patches/redir_onlink_10_rev1.diff Thanks in advance, Eric ==== Fix the Redirected On-Link test cases in the Tahi IPv6 Ready Logo Phase 2 test suite. On receipt of a redirect message, install an interface route for the redirected destination. On removal of the corresponding Neighbor Cache entry, remove the interface route. This requires changes in rtredirect_fib() to cope with an AF_LINK address for the gateway and with the absence of RTF_GATEWAY. Unrelated to the above, fix a recursion on the radix node head lock triggered by the Redirected to Alternate Router test cases. All Section 2 (Neighbor Discovery) test cases pass on 10-CURRENT and 9-STABLE. (8-STABLE pending) Other test cases: * the RTF_MODIFIED case, with IPv4 and IPv6 (using a RTF_HOST|RTF_GATEWAY route for the destination) * the redirected-to-self case, with IPv4 and IPv6 * a valid IPv4 redirect All testing was done with WITNESS and INVARIANTS. Submitted by: Eric van Gyzen , Mark Kelley , Terence Telkamp Sponsored by: Dell, Inc. PR: kern/152791