From owner-cvs-src@FreeBSD.ORG Thu Aug 12 02:15:45 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BA77016A4CE; Thu, 12 Aug 2004 02:15:45 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A70C43D1D; Thu, 12 Aug 2004 02:15:45 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.51] (adsl-64-171-186-94.dsl.snfc21.pacbell.net [64.171.186.94]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i7C2Fi8U009039; Wed, 11 Aug 2004 19:15:44 -0700 Message-ID: <411AD2CF.9070608@root.org> Date: Wed, 11 Aug 2004 19:15:43 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, src-committers@FreeBSD.org References: <20040812020625.0BD8616A570@hub.freebsd.org> In-Reply-To: <20040812020625.0BD8616A570@hub.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci_link.c acpi_pcib.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2004 02:15:45 -0000 Nate Lawson wrote: > FreeBSD src repository > > Modified files: > sys/dev/acpica acpi_pci_link.c acpi_pcib.c > Log: > Fix the PRT entry code in acpi_pci_link to always add the entry, even if > there is no irq link. Since we now use the stored copy of PRT, not the > one that used to be passed into acpi_pcib_route_interrupt(), we need it in > the list. [1] > > Fix a bug in acpi_pci_find_prt() where we weren't checking the bus, thus > choosing the wrong PRT entry to use for routing the link. Also, add a > printf for the case where the PRT entry is not found as this should not > happen. > > Tested by: marcel [1] > > Revision Changes Path > 1.21 +40 -41 src/sys/dev/acpica/acpi_pci_link.c > 1.48 +4 -1 src/sys/dev/acpica/acpi_pcib.c These bugs were most apparent on APIC machines, especially those with lots of PCI busses. Hardcoded IRQs should now work correctly. -- Nate