From owner-freebsd-xen@freebsd.org Thu May 24 15:09:18 2018 Return-Path: Delivered-To: freebsd-xen@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AAEB8EF4312 for ; Thu, 24 May 2018 15:09:18 +0000 (UTC) (envelope-from pratiy0100@gmail.com) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2CE8B70FC5 for ; Thu, 24 May 2018 15:09:17 +0000 (UTC) (envelope-from pratiy0100@gmail.com) Received: by mail-wm0-f67.google.com with SMTP id t11-v6so6134659wmt.0 for ; Thu, 24 May 2018 08:09:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wAn/tlHcnDnYjXoWtUv50bpusx+Fp3O3zNAMM39iTiw=; b=JArTQ7Y6H8MVKKgp7xvzIffkqRce71mQMiDVLMIxT76F8/a4Evi7kdAokmBVlxkoxk AoB1Kb3HsEDtDVVHeNlYMZIGr2NlDsn9406Qp+9qtta4vEoyVune7+DALP9uAg2RabhC 1DeUeRNIWw/U81EDZiGYDCQ63srKAQk5lUo5G80cYknOyVkyFJl6aNZhm9FuI1sLnrlV c+p6UcioMiSdtKMt6hyD2oAvt90D1QPvWsIEHMECf5qiLz4At2AjBAX0dCcDMuaZtYSZ rwwtRQo7vCUL10n/qzHkbLL3kmpyUnskRH++nbWBgNqxynDCkeXRDK7g3z+WRX5LL3EZ x1Sg== X-Gm-Message-State: ALKqPweRuUoy4iwsxIKDw92V7Qzv6RDGGucMJTz2VN8LN/JBVQKOh6lF sFRkuNjZE4TVnbOvRtfoM+U8O3BAPIs= X-Google-Smtp-Source: AB8JxZpb1QiVjKmJ4aToQotQNgmq01KHK1GDCEiJyLd2aWjBP+wZTT17CLpMBv/RCyWw0wmNk2WNmQ== X-Received: by 2002:a50:a985:: with SMTP id n5-v6mr12706906edc.112.1527174551466; Thu, 24 May 2018 08:09:11 -0700 (PDT) Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com. [74.125.82.52]) by smtp.gmail.com with ESMTPSA id e6-v6sm11345657eds.20.2018.05.24.08.09.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 May 2018 08:09:11 -0700 (PDT) Received: by mail-wm0-f52.google.com with SMTP id j4-v6so6135626wme.1 for ; Thu, 24 May 2018 08:09:11 -0700 (PDT) X-Received: by 2002:a50:8561:: with SMTP id 88-v6mr1698921edr.119.1527174550872; Thu, 24 May 2018 08:09:10 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a50:aa21:0:0:0:0:0 with HTTP; Thu, 24 May 2018 08:08:30 -0700 (PDT) In-Reply-To: <20180524140636.7vz2gjshqow6efwe@MBP-de-Roger.citrite.net> References: <20180524140636.7vz2gjshqow6efwe@MBP-de-Roger.citrite.net> From: Pratyush Yadav Date: Thu, 24 May 2018 20:38:30 +0530 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Leftover code in gnttab.h? To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: FreeBSD-Xen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 15:09:18 -0000 Hi, On Thu, May 24, 2018 at 7:36 PM, Roger Pau Monn=C3=A9 wrote: > On Thu, May 24, 2018 at 05:53:02PM +0530, Pratyush Yadav wrote: >> Hi everyone, >> >> I was reading the Xen grant table code and I noticed that some code is >> wrapped in an #if 0. You can see it in sys/xen/gnttab.h:138. I have >> also attached the "commented out" part down below. >> >> Is it useful? Is it all right if I submit a patch that removes it? > > This are leftovers from when the code was imported from Linux AFAICT. > I guess the original committer thought that those functions would be > implemented, so the prototypes where left in place. > > If you give me a patch to remove them I'm happy to commit it. How should I send you the patch? Should I send it through reviews.freebsd.org, GitHub pull request or just paste the patch in the email? --=20 Regards, Pratyush Yadav