From owner-svn-src-all@freebsd.org Tue Feb 27 16:36:46 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CFDCBF35437 for ; Tue, 27 Feb 2018 16:36:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6347581C2A for ; Tue, 27 Feb 2018 16:36:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x244.google.com with SMTP id o9so15767706itc.1 for ; Tue, 27 Feb 2018 08:36:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=EYPnSW+mRXVfOQXM0ZqvQTlA1g/kiYxlsGTG2NSBPJ0=; b=Ouek8fDdZdbKuooM5aeR4cVGvdXerBLpGHRki/HQlPDCFUOhhnm74RbDl1AQ+WVEWH kl4QylhJg2tqb7Qa2rlKM1nzS2Ipc3YHIZeA6IF0FMPFnicpjCiYtCQAU9sFryk3jUBD eRlQkBZ+3wM9JezgN35bO/dnaRxVINAcqFI5BsbwHZnjAoTWzrN2m21dCaQ6TmliNqXZ Gi3zX04svfnAoxvpommhvhlh4i/DD+QKhaRACBD8rZe3IvI+sEcO5oY/L0ZaXwoUFRoo bSY0PAnHFUvr1mkZHy6Czn9NtT1WHLQV9iOgjc/VR9PmMK0N3JVmKOfzfA8lQSkvqqj6 r/tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=EYPnSW+mRXVfOQXM0ZqvQTlA1g/kiYxlsGTG2NSBPJ0=; b=eGB/LG7De19XbR3j4w/zzpu005sqCQtFtrsNU8jBPc6gl+4iOzVJUjwAc+1WIRJeWt pwa4GnQ2eAOwY3Wva9E03MO9BB3eUlJilw/kj9DSz+ot5sS3iMA6f103bs/TjZQOIMSu DDWCT+Jwxap1iHjTba+eCQouZ4bczETmUBn5Yv5UxlE/iuFcom3NQHe8IAwLZ06YS3Lg WNjwVqGHG+Plkpk1um3ej9lneI1YKqSa5eQacR7NSO00cuI3jQwoec2uGaTt85RLcydI CZ4Z63UUgagxEM2MS9ecRhr5PQSiC6MKLLitcAoVbluiyhzFUjmBiV49gPVH6oAXQPaZ C+zw== X-Gm-Message-State: APf1xPDcnnvFE1/3QTr3GM/QI90/jiFzqgGfu5BjBomjfRkGKNA/r1Wt mld6Tp9Cnc1oYXefmEcGYsqrIOFleVi/T2va3zMfsw== X-Google-Smtp-Source: AH8x226y/3PFb3gFQOmDCMBakS3EM4upbvLHUTzIzqsmx+9248rKs6jf91xTr4LKAXQnf9cAxPuh9wsC1XAcuQ5aeGo= X-Received: by 10.36.222.2 with SMTP id d2mr17045043itg.1.1519749404539; Tue, 27 Feb 2018 08:36:44 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.201.67 with HTTP; Tue, 27 Feb 2018 08:36:43 -0800 (PST) X-Originating-IP: [50.227.106.226] In-Reply-To: References: <201802260316.w1Q3G4vc022314@repo.freebsd.org> From: Warner Losh Date: Tue, 27 Feb 2018 09:36:43 -0700 X-Google-Sender-Auth: oay5d4KViIPRG5P3UvxM5e_e5GM Message-ID: Subject: Re: svn commit: r330004 - in head/stand: . arm efi forth i386 mips powerpc sparc64 To: Kyle Evans Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 16:36:46 -0000 On Tue, Feb 27, 2018 at 8:33 AM, Kyle Evans wrote: > n Tue, Feb 27, 2018 at 9:28 AM, Kyle Evans wrote: > > On Sun, Feb 25, 2018 at 9:16 PM, Warner Losh wrote: > >> Author: imp > >> Date: Mon Feb 26 03:16:04 2018 > >> New Revision: 330004 > >> URL: https://svnweb.freebsd.org/changeset/base/330004 > >> > >> Log: > >> Add NO_OBJ to those directories that don't make anything. > >> > >> For directories that don't many anything, add NO_OBJ=t just before we > >> include bsd.init.mk. This prevents them from creating an OBJ > >> directory. In addition, prevent defs.mk from creating the machine > >> related links in these cases. They aren't needed and break, at least > >> on stable, the read-only src tree build. > >> > > > > Any objection to also removing efi from i386 SUBDIR? It seems silly > > to be explicitly adding it when we know nothing here is applicable and > > it's going to take some amount of work to get there. > > In fact, this block [1] feels wrong, too... why are we adding efi to > SUBDIR for arch's that don't support it? I understand the GCC checks, > but libefi, loader, and boot1 are the main bits of efi/, why are these > stuck behind MACHINE_CPUARCH checks? > > [1] https://svnweb.freebsd.org/base/head/stand/efi/Makefile? > view=markup#l17 > I think that none of the arch tests in that file are anywhere near legit in that file. More cargo-cult kludgery to eliminate in the build system. I'll take care of that. If i386 builds, we should keep it, otherwise we shouldn't. In fact, we should move all the EFI ifdef junk-o-matic crap from Makefile. at the top level as well. Lemme toss together a patch. Warner