From owner-svn-ports-all@FreeBSD.ORG Mon Oct 8 17:06:07 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id F045F106564A for ; Mon, 8 Oct 2012 17:06:06 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B2F738FC18 for ; Mon, 8 Oct 2012 17:06:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q98H66rQ079335 for ; Mon, 8 Oct 2012 17:06:06 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q98H66EV079329 for svn-ports-all@freebsd.org; Mon, 8 Oct 2012 17:06:06 GMT (envelope-from bdrewery) Received: (qmail 54218 invoked from network); 8 Oct 2012 12:06:02 -0500 Received: from unknown (HELO ?10.10.0.115?) (freebsd@shatow.net@10.10.0.115) by sweb.xzibition.com with ESMTPA; 8 Oct 2012 12:06:02 -0500 Message-ID: <507307F7.3030406@FreeBSD.org> Date: Mon, 08 Oct 2012 12:05:59 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20120907 Thunderbird/15.0.1 MIME-Version: 1.0 To: Chris Rees References: <201210061123.q96BNHVx053948@svn.freebsd.org> <20121008040154.GB91369@FreeBSD.org> <20121008045905.GD91369@FreeBSD.org> <20121008071642.GA91360@ithaqua.etoilebsd.net> In-Reply-To: X-Enigmail-Version: 1.4.4 OpenPGP: id=3C9B0CF9; url=http://www.shatow.net/bryan/bryan.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, Baptiste Daroussin , Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r305357 - head/net/ssvnc X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2012 17:06:07 -0000 On 10/8/2012 12:02 PM, Chris Rees wrote: > On 8 October 2012 08:16, Baptiste Daroussin wrote: >> On Mon, Oct 08, 2012 at 04:59:06AM +0000, Alexey Dokuchaev wrote: >>> On Mon, Oct 08, 2012 at 04:01:54AM +0000, Alexey Dokuchaev wrote: >>>> On Sat, Oct 06, 2012 at 11:23:17AM +0000, Baptiste Daroussin wrote: >>>>> New Revision: 305357 >>>>> URL: http://svn.freebsd.org/changeset/ports/305357 >>>>> >>>>> Log: >>>>> fix sense of a test >>>>> >>>>> -.if ${PORT_OPTIONS:MULTRAFTP} >>>>> +.if empty(PORT_OPTIONS:MULTRAFTP) >>>> >>>> That looks weird, and commit message is pretty cryptic as well. Could you >>>> explain what went wrong here so others would not fall in the same pitfall? >>> >>> Err, I read is as ! vs. empty() test. Still, I've noticved some arguments >>> on the syntax, would be nice to know if ! ${PORT_OPTIONS:M...} has issues >>> other than purely stylish. >>> >> >> No it hasn't (as far as I know) >> > > This is all my fault-- I was the one who suggested the original use of > ${FOO:M}, and I deliberately chose to retain empty(FOO) as the reverse > because I was convinced that the insanity of make's conditionals would > screw us over in some way. > > I have at [1] pulled together some simple tests, and I think I've > caught all use cases here. > > It seems to work fine-- are there any people more wizardly than me > with make that can confirm that it's OK? If so, I'll update the docs. > > Chris > > [1] http://www.bayofrum.net/~crees/scratch/Makefile-do-we-need-empty-after-all > Can you add: !${PORT_OPTIONS:MFOO} && !${PORT_OPTIONS:MBAR} I swear there is a case where !${} results in an Error. -- Regards, Bryan Drewery bdrewery@freenode/EFNet