Date: Tue, 25 Feb 2020 17:51:38 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 244401] print/libraqm: Fix build with clang 10.0.0 Message-ID: <bug-244401-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244401 Bug ID: 244401 Summary: print/libraqm: Fix build with clang 10.0.0 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: kwm@FreeBSD.org Reporter: dim@FreeBSD.org Blocks: 244251 Assignee: kwm@FreeBSD.org Flags: maintainer-feedback?(kwm@FreeBSD.org) Created attachment 211932 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D211932&action= =3Dedit Fix comparisons in libraqm As reported in bug 244251, with clang 10.0.0 the print/libraqm port runs in= to several -Werror warnings: raqm.c:1934:24: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare] if (ch !=3D 0x102B || ch !=3D 0x102C || ch !=3D 0x1038 || ~~~~~~~~~~~~~^~~~~~~~~~~~~~~ raqm.c:1937:25: error: overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare] (ch <=3D 0x109A && ch >=3D 0x109C) || ch !=3D 0x1A61 || ch !=3D 0= x1A63 || ~~~~~~~~~~~~~^~~~~~~~~~~~~~~ raqm.c:1936:41: error: overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare] ch !=3D 0x1083 || (ch <=3D 0x1087 && ch >=3D 0x108C) || ch !=3D 0= x108F || ~~~~~~~~~~~~~^~~~~~~~~~~~~~~ raqm.c:1935:59: error: overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare] (ch <=3D 0x1062 && ch >=3D 0x1064) || (ch <=3D 0x1067 && ch >=3D = 0x106D) || ~~~~~~~~~~~~~^~~~~~~~~~~~~~~ raqm.c:1935:25: error: overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare] (ch <=3D 0x1062 && ch >=3D 0x1064) || (ch <=3D 0x1067 && ch >=3D = 0x106D) || ~~~~~~~~~~~~~^~~~~~~~~~~~~~~ 5 errors generated. The comparisons are clearly invalid as written, and this is most likely due= to incorrect boolean inversion done on the negated expression. This problem has been reported upstream too: https://github.com/HOST-Oman/libraqm/issues/115 The attached patch is what I have also proposed upstream. Referenced Bugs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244251 [Bug 244251] [exp-run] Against projects/clang1000-import branch --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-244401-7788>