From owner-svn-src-all@FreeBSD.ORG Tue Feb 17 20:22:04 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C910261F; Tue, 17 Feb 2015 20:22:04 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 53AE6E19; Tue, 17 Feb 2015 20:22:03 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t1HKLsNj064675 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 17 Feb 2015 23:21:54 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t1HKLsZ5064674; Tue, 17 Feb 2015 23:21:54 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 17 Feb 2015 23:21:54 +0300 From: Gleb Smirnoff To: John-Mark Gurney Subject: Re: svn commit: r278831 - head/sys/netpfil/pf Message-ID: <20150217202154.GS15484@FreeBSD.org> References: <201502160338.t1G3cRlX042385@svn.freebsd.org> <20150217173134.GZ1953@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150217173134.GZ1953@funkthat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 20:22:04 -0000 On Tue, Feb 17, 2015 at 09:31:34AM -0800, John-Mark Gurney wrote: J> Gleb Smirnoff wrote this message on Mon, Feb 16, 2015 at 03:38 +0000: J> > Author: glebius J> > Date: Mon Feb 16 03:38:27 2015 J> > New Revision: 278831 J> > URL: https://svnweb.freebsd.org/changeset/base/278831 J> > J> > Log: J> > Update the pf fragment handling code to closer match recent OpenBSD. J> > That partially fixes IPv6 fragment handling. Thanks to Kristof for J> > working on that. J> > J> > Submitted by: Kristof Provost J> > Tested by: peter J> > Differential Revision: D1765 J> J> Looks like pf_flush_fragments still called in !INET case, though only J> defined for INET case: J> /scratch/tmp/jmg/src.head/sys/modules/pf/../../netpfil/pf/pf_norm.c:385:3: error: implicit declaration of function 'pf_flush_fragments' is invalid in C99 [-Werror,-Wimplicit-function-declaration] J> pf_flush_fragments(); J> J> when compiling LINT-NOINET kernel.. J> J> at least as of r278883... J> J> We need to get Jenkins to be compiling the LINT-NOINET kernel too.. Strange, since r278874 was tested with KERNCONF="LINT LINT-NOINET LINT-NOINET6". I will take a look. -- Totus tuus, Glebius.