From owner-freebsd-bugs@FreeBSD.ORG Tue Oct 14 16:00:10 2008 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB7E3106568E for ; Tue, 14 Oct 2008 16:00:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C7D538FC27 for ; Tue, 14 Oct 2008 16:00:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id m9EG08Wo013513 for ; Tue, 14 Oct 2008 16:00:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id m9EG083q013512; Tue, 14 Oct 2008 16:00:08 GMT (envelope-from gnats) Resent-Date: Tue, 14 Oct 2008 16:00:08 GMT Resent-Message-Id: <200810141600.m9EG083q013512@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Henning Petersen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 227D6106569A for ; Tue, 14 Oct 2008 15:59:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 10D348FC1C for ; Tue, 14 Oct 2008 15:59:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id m9EFxfvr016905 for ; Tue, 14 Oct 2008 15:59:41 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id m9EFxfjk016904; Tue, 14 Oct 2008 15:59:41 GMT (envelope-from nobody) Message-Id: <200810141559.m9EFxfjk016904@www.freebsd.org> Date: Tue, 14 Oct 2008 15:59:41 GMT From: Henning Petersen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/128096: Failure in memset . X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Oct 2008 16:00:11 -0000 >Number: 128096 >Category: bin >Synopsis: Failure in memset . >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Oct 14 16:00:08 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Henning Petersen >Release: current-Freebsd >Organization: >Environment: >Description: >How-To-Repeat: >Fix: --- src/usr.sbin/nscd/agents/services.c 27 Sep 2007 12:30:10 -0000 1.3 +++ src/usr.sbin/nscd/agents/services.c 14 Oct 2008 07:31:06 -0000 @@ -171,7 +171,7 @@ if (size > 0) { proto = (char *)malloc(size + 1); assert(proto != NULL); - memset(proto, size + 1, 0); + memset(proto, 0, size + 1); memcpy(proto, key + sizeof(enum nss_lookup_type) + sizeof(int), size); } Patch attached with submission follows: Index: src/usr.sbin/nscd/agents/services.c =================================================================== RCS file: /usr/ncvs/src/usr.sbin/nscd/agents/services.c,v retrieving revision 1.3 diff -u -r1.3 services.c --- src/usr.sbin/nscd/agents/services.c 27 Sep 2007 12:30:10 -0000 1.3 +++ src/usr.sbin/nscd/agents/services.c 14 Oct 2008 07:31:06 -0000 @@ -171,7 +171,7 @@ if (size > 0) { proto = (char *)malloc(size + 1); assert(proto != NULL); - memset(proto, size + 1, 0); + memset(proto, 0, size + 1); memcpy(proto, key + sizeof(enum nss_lookup_type) + sizeof(int), size); } >Release-Note: >Audit-Trail: >Unformatted: