From owner-svn-src-stable-8@FreeBSD.ORG Sun Nov 6 23:26:18 2011 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 13946106566B; Sun, 6 Nov 2011 23:26:18 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe02.c2i.net [212.247.154.34]) by mx1.freebsd.org (Postfix) with ESMTP id 111788FC13; Sun, 6 Nov 2011 23:26:16 +0000 (UTC) X-T2-Spam-Status: No, hits=-1.0 required=5.0 tests=ALL_TRUSTED, BAYES_20 Received: from [188.126.198.129] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe02.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 201163649; Mon, 07 Nov 2011 00:16:11 +0100 From: Hans Petter Selasky To: Marius Strobl Date: Mon, 7 Nov 2011 00:13:09 +0100 User-Agent: KMail/1.13.5 (FreeBSD/8.2-STABLE; KDE/4.4.5; amd64; ; ) References: <20111106194743.GD56603@alchemy.franken.de> <20111106203800.GE56603@alchemy.franken.de> In-Reply-To: <20111106203800.GE56603@alchemy.franken.de> X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5 %V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC( :AuzV9:.hESm-x4h240C`9=w MIME-Version: 1.0 Content-Type: Text/Plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Message-Id: <201111070013.09627.hselasky@c2i.net> Cc: "svn-src-stable@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , "svn-src-stable-8@freebsd.org" Subject: Re: svn commit: r227217 - stable/8/sys/dev/usb X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Nov 2011 23:26:18 -0000 On Sunday 06 November 2011 21:38:00 Marius Strobl wrote: > On Sun, Nov 06, 2011 at 08:47:43PM +0100, Marius Strobl wrote: > > On Sun, Nov 06, 2011 at 03:13:02PM +0000, Hans Petter Selasky wrote: > > > Author: hselasky > > > Date: Sun Nov 6 15:13:01 2011 > > > New Revision: 227217 > > > URL: http://svn.freebsd.org/changeset/base/227217 > > > > > > Log: > > > MFC r227075: > > > Fix for panic at USB controller attach failure during cold boot. > > > > > > Modified: > > > stable/8/sys/dev/usb/usb_process.c > > > > > > Directory Properties: > > > stable/8/sys/ (props changed) > > > stable/8/sys/amd64/include/xen/ (props changed) > > > stable/8/sys/cddl/contrib/opensolaris/ (props changed) > > > stable/8/sys/contrib/dev/acpica/ (props changed) > > > stable/8/sys/contrib/pf/ (props changed) > > > > > > Modified: stable/8/sys/dev/usb/usb_process.c > > > ======================================================================= > > > ======= --- stable/8/sys/dev/usb/usb_process.c Sun Nov 6 15:06:04 > > > 2011 (r227216) +++ stable/8/sys/dev/usb/usb_process.c Sun Nov 6 > > > 15:13:01 2011 (r227217) @@ -67,11 +67,13 @@ static int usb_pcount; > > > > > > #define USB_THREAD_CREATE(f, s, p, ...) \ > > > > > > kproc_kthread_add((f), (s), &usbproc, (p), RFHIGHPID, \ > > > > > > 0, "usb", __VA_ARGS__) > > > > > > +#define USB_THREAD_SUSPEND_CHECK() kthread_suspend_check() > > > > In stable/8 kthread_suspend_check(9) takes an struct thread * argument. > > Sorry, I didn't look closely enough, it probably should use the same > approach as hptmv(4): > #if (__FreeBSD_version >= 800002) > kproc_suspend_check(curproc); > #elif (__FreeBSD_version >= 500043) > kthread_suspend_check(curproc); > #else > kproc_suspend_loop(curproc); > #endif > > In any case, r227217 broke kernel compilation of stable/8. Hi, I'll fix this ASAP. Sorry for the inconvenience. --HPS