From owner-svn-src-all@freebsd.org Wed Aug 10 11:02:40 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6DA44BB4257; Wed, 10 Aug 2016 11:02:40 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 95AB616A5; Wed, 10 Aug 2016 11:02:39 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u7AB2TTD099305 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 10 Aug 2016 14:02:29 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u7AB2TTD099305 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u7AB2TjB099304; Wed, 10 Aug 2016 14:02:29 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 10 Aug 2016 14:02:29 +0300 From: Konstantin Belousov To: Jean-S??bastien P??dron Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303890 - in head/sys: contrib/ncsw/user/env contrib/octeon-sdk dev/auxio dev/bktr dev/e1000 dev/ixgb dev/ixgbe dev/ixl dev/netmap dev/pci dev/sound/sbus dev/tpm kern mips/nlm/dev/net m... Message-ID: <20160810110229.GK83214@kib.kiev.ua> References: <201608091932.u79JW6Y6069448@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201608091932.u79JW6Y6069448@repo.freebsd.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2016 11:02:40 -0000 On Tue, Aug 09, 2016 at 07:32:06PM +0000, Jean-S??bastien P??dron wrote: > Author: dumbbell > Date: Tue Aug 9 19:32:06 2016 > New Revision: 303890 > URL: https://svnweb.freebsd.org/changeset/base/303890 > > Log: > Consistently use `device_t` > > Several files use the internal name of `struct device` instead of > `device_t` which is part of the public API. This patch changes all > `struct device *` to `device_t`. > > The remaining occurrences of `struct device` are those referring to the > Linux or OpenBSD version of the structure, or the code is not built on > FreeBSD and it's unclear what to do. > > Submitted by: Matthew Macy (previous version) > Approved by: emaste, jhibbits, sbruno > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D7447 On powerpc and powerpc64, at r303902, I got ===> usr.sbin/camdd (all) In file included from /scratch/tmp/kib/obj/powerpc.powerpc64/scratch/tmp/kib/src /tmp/usr/include/machine/bus.h:463, from /scratch/tmp/kib/src/usr.sbin/camdd/camdd.c:54: /scratch/tmp/kib/obj/powerpc.powerpc64/scratch/tmp/kib/src/tmp/usr/include/machi ne/bus_dma.h:33: error: expected declaration specifiers or '...' before 'device_ t' --- camdd.o --- *** [camdd.o] Error code 1