Date: Tue, 19 Jul 2022 20:42:45 +0000 From: Glen Barber <gjb@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: "Rodney W. Grimes" <freebsd-rwg@gndrsh.dnsmgr.net>, Mark Millard <marklmi@yahoo.com>, Warner Losh <imp@bsdimp.com>, dev-commits-src-main@freebsd.org, "Dr. Rolf Jansen" <freebsd-rj@cyclaero.com>, freebsd-arm <freebsd-arm@freebsd.org> Subject: Re: git: 1dfcff294e44 - main - release: increase IMAGE_SIZE for arm, arm64, riscv [odd alignment for SBC images] Message-ID: <20220719204245.GL30607@FreeBSD.org> In-Reply-To: <CAPyFy2D1aBe8h4kq=RqCR2tkEiEXh_pHNEqaAnW7tk9-HxCmBQ@mail.gmail.com> References: <16906DFD-286B-4D59-9438-CA9CD9026C55@yahoo.com> <202207171708.26HH81bA062303@gndrsh.dnsmgr.net> <CAPyFy2D1aBe8h4kq=RqCR2tkEiEXh_pHNEqaAnW7tk9-HxCmBQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--N5vNW3dQ2P5lHuuL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Jul 19, 2022 at 04:35:36PM -0400, Ed Maste wrote:
> On Sun, 17 Jul 2022 at 13:08, Rodney W. Grimes
> <freebsd-rwg@gndrsh.dnsmgr.net> wrote:
>=20
> > Perhaps an assert for kern.geom.part.mbr.enforce_chs not
> > being zero in /usr/src/release scripts is in order so that
> > the builds blow up rather than produce BAD images.
>=20
> This is a good interim step (before switching to mkimg).
>=20
> Perhaps:
>=20
> diff --git a/release/tools/arm.subr b/release/tools/arm.subr
> index 77b708bca4a2..94e0ee89deaf 100644
> --- a/release/tools/arm.subr
> +++ b/release/tools/arm.subr
> @@ -62,6 +62,10 @@ umount_loop() {
> }
>=20
> arm_create_disk() {
> + if [ $(sysctl -n kern.geom.part.mbr.enforce_chs) !=3D 0 ]; then
> + return 1
> + fi
> +
> # Create the target raw file and temporary work directory.
> chroot ${CHROOTDIR} gpart create -s ${PART_SCHEME} ${mddev}
> if [ "${PART_SCHEME}" =3D "GPT" ]; then
>=20
My concern with this is kern.geom.part.mbr.enforce_chs is always '1' on
the builders, which effectively means all arm builds will fail every
time. I think we need to get to the actual root of the problem here,
versus applying band-aids to a shark bite.
Glen
--N5vNW3dQ2P5lHuuL
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEjRJAPC5sqwhs9k2jAxRYpUeP4pMFAmLXF0UACgkQAxRYpUeP
4pP0Xw//dXvzRH/1zx6wY1RT/2R5sGBlwnfrPdeeqH35cC7OJqWiwe3O3ZarDO1D
Z7LNQmufk4vKAJZNhZQFljbCCoHUNttc4p8uycBI7FYDDDscRGiZOcVW7t2c5qEx
pqR9cSOHzptBbcjlSNh8iMBy4/8uDPlmcPV4ziLkH5+tQYIjNjoCZ/9fECy4eHRP
SubclHPx9e9ZKqqTd86Iry3MUdgNI8B8x032RRUPAmIzgiLo1fEhdDY/tzTrqIvj
usOS+XOLRRTNNWw1oL2+thDVscsXE4cpJjZ7+5xElssUQG5upKVOg+zNnStAJmtC
IodWmEb8rasyo5I3Ho/ILLo5Rw5o1jIk4cAeGhfWgP+OBviq+6SGSq83PKD4f92X
zHzW+aqSDOZSZNTRwg2/nUoNVsl22IVX5G7QkNacOCcBZMZ0iLTLkRcXtOe2cVlZ
8Yp9WuJnCmZPe8J5j+x8wt6wcD93VnlCbhNfYE4+z3ZXoMVacAad5SeV5jWTX/b8
4sODcOqQsPUQwXsqby0P0+DB52G3EzneF6xTm2iFB/mVo84q6zw8qrXyw371RlG9
DxJL+x7EZSM7rZ3jutoDxEQGrdf95D4zv5GdP2qhYFMD8DVVqutbzV7twnrx2goS
Bolo0Y9XbJMgg25xw8FXecJ5YxQRWtpnnLoSqIeUmq/TCcd7+zE=
=izbc
-----END PGP SIGNATURE-----
--N5vNW3dQ2P5lHuuL--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220719204245.GL30607>