Skip site navigation (1)Skip section navigation (2)
Date:      Thu,  7 Feb 2008 10:45:05 -0500 (EST)
From:      Naram Qashat <cyberbotx@cyberbotx.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        beech@FreeBSD.org
Subject:   ports/120351: [PATCH] multimedia/xmms: Properly respect OPTIONS
Message-ID:  <20080207154505.4D48AC0FB@kirby.cyberbotx.com>
Resent-Message-ID: <200802071550.m17Fo3F6079183@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         120351
>Category:       ports
>Synopsis:       [PATCH] multimedia/xmms: Properly respect OPTIONS
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 07 15:50:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Naram Qashat
>Release:        FreeBSD 6.3-RELEASE i386
>Organization:
>Environment:
System: FreeBSD kirby.cyberbotx.com 6.3-RELEASE FreeBSD 6.3-RELEASE #0: Wed Jan 23 16:14:04 EST 2008
>Description:
- Properly respect OPTIONS (using !defined(WITHOUT_*) instead of defined(WITH_*)
  for OPTIONS set to on)

Port maintainer (beech@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- xmms-1.2.11_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/multimedia/xmms/Makefile /kirby/shared/ports/xmms/Makefile
--- /usr/ports/multimedia/xmms/Makefile	2008-02-01 10:23:28.000000000 -0500
+++ /kirby/shared/ports/xmms/Makefile	2008-02-07 10:39:40.000000000 -0500
@@ -56,7 +56,7 @@
 PLIST_SUB+=	NLS="@comment "
 .endif
 
-.if defined(WITH_IPV6)
+.if !defined(WITHOUT_IPV6)
 CONFIGURE_ARGS+=	--enable-ipv6
 .endif
 
@@ -74,7 +74,7 @@
 CFLAGS+=	-DALL_VORBIS_TAGS
 .endif
 
-.if defined(WITH_MIKMOD)
+.if !defined(WITHOUT_MIKMOD)
 LIB_DEPENDS+=	mikmod.2:${PORTSDIR}/audio/libmikmod
 INPUT_PLUGINS+=	mikmod
 PLIST_SUB+=	MIKMODPLUGIN:=""
@@ -83,7 +83,7 @@
 PLIST_SUB+=	MIKMODPLUGIN:="@comment "
 .endif
 
-.if defined(WITH_VORBIS)
+.if !defined(WITHOUT_VORBIS)
 LIB_DEPENDS+=	vorbis.4:${PORTSDIR}/audio/libvorbis
 INPUT_PLUGINS+=	vorbis
 PLIST_SUB+=	VORBISPLUGIN:=""
@@ -105,7 +105,7 @@
 WITHOUT_SIMD+=	yes
 .endif
 
-.if defined(WITH_SIMD)
+.if !defined(WITHOUT_SIMD)
 CONFIGURE_ARGS+=	--enable-simd
 .endif
 
@@ -151,7 +151,7 @@
 .  endfor
 .endif
 # If there is no esound installed, the autotools won't find a required macro
-.if !${HAVE_GNOME:Mesound}!=""
+.if ${HAVE_GNOME:Mesound}==""
 	${REINPLACE_CMD} -e '/AM_PATH_ESD/,/have_esd=no/d' ${WRKSRC}/configure.in
 .endif
 
--- xmms-1.2.11_2.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080207154505.4D48AC0FB>