From owner-freebsd-current@freebsd.org Wed Aug 2 16:14:27 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C69CBDD438E for ; Wed, 2 Aug 2017 16:14:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A34CF6B2A3; Wed, 2 Aug 2017 16:14:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 3137E10AF0F; Wed, 2 Aug 2017 12:14:26 -0400 (EDT) From: John Baldwin To: Andriy Gapon Cc: "Ngie Cooper (yaneurabeya)" , FreeBSD Current Subject: Re: zfs.ko no longer loads after r320156: unresolved symbol: abd_is_linear Date: Wed, 02 Aug 2017 09:07:18 -0700 Message-ID: <14630232.pvpQT5dAYX@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: References: <780A67EE-C3F1-46E5-A213-E253B710338E@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 02 Aug 2017 12:14:26 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2017 16:14:27 -0000 On Wednesday, August 02, 2017 10:14:01 AM Andriy Gapon wrote: > On 02/08/2017 04:00, Ngie Cooper (yaneurabeya) wrote: > >=20 > >> On Aug 1, 2017, at 09:21, John Baldwin wrote: > >> > >> On Tuesday, August 01, 2017 09:47:41 AM Andriy Gapon wrote: > >>> On 01/08/2017 02:31, Ngie Cooper wrote: > >>>> Hi, > >>>> =09I tried upgrading my host from 11.1-STABLE to 12.0-CURRENT, a= nd it didn=E2=80=99t work because abd_is_linear is an undefined symbol = (it exists in sys/conf/files, but not sys/modules/zfs/Makefile). I trie= d adding abd.c to sys/modules/zfs/Makefile and it didn=E2=80=99t immedi= ately fix my compilation problem (ran into a linker error instead). > >>>> =09If it isn=E2=80=99t fixed in the next few hours I=E2=80=99ll = try my hand at fixing the problem. > >>> > >>> I am not sure what exact problem you have... > >>> abd.c should be added to the list of source files via > >>> .include "${SUNW}/uts/common/Makefile.files" > >>> > >>> Perhaps something to do with "inline"... > >> > >> Oh, yes. If you use -fno-inline-funcs or the like. I forgot to > >> send this to Andriy earlier, but here is the fix I'm using: > >> > >> https://github.com/freebsd/freebsd/commit/574dc95cf8272e16f6d44aff= 6cb4e08dede08886 > >=20 > > =09Unfortunately=E2=80=A6 this is head, verbatim, which means that = the bug still exists. > > =09This gives me an idea of where I should look though. >=20 > The URL indeed suggests that the change should be in head, but it's n= ot there as > far as I can tell. I never saw it being committed. Not yet. I'm trying to decide if 'static inline' is more correct (for = me it results in 3 separate copies of abd_is_linear in zfs.ko) vs using 'exte= rn inline'. The latter seems possibly more correct but more of a pain? I= think for that it needs to be extern in only a single file and 'inline' in th= e header? --=20 John Baldwin